Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: fix Vue3 example #3774

Merged
merged 5 commits into from Jun 29, 2022
Merged

example: fix Vue3 example #3774

merged 5 commits into from Jun 29, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented May 23, 2022

Blocked on the ESM transition (currently getting require is not defined when trying to upload a file). no longer blocked, it now works fine on the 3.x thanks to the ESM transition.

@aduh95 aduh95 changed the base branch from main to 3.x May 31, 2022 17:38
@aduh95 aduh95 marked this pull request as ready for review May 31, 2022 17:38
@arturi arturi self-requested a review June 13, 2022 04:09
Copy link
Contributor

@arturi arturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well! Happy happy 🕺

@aduh95 aduh95 merged commit 0d88c8e into 3.x Jun 29, 2022
@aduh95 aduh95 deleted the vue3-example branch June 29, 2022 13:49
github-actions bot added a commit that referenced this pull request Jul 6, 2022
| Package              |      Version | Package              |      Version |
| -------------------- | ------------ | -------------------- | ------------ |
| @uppy/companion      | 4.0.0-beta.1 | @uppy/transloadit    | 3.0.0-beta.2 |
| @uppy/locales        | 3.0.0-beta.2 | @uppy/robodog        | 3.0.0-beta.2 |
| @uppy/provider-views | 3.0.0-beta.2 | uppy                 | 3.0.0-beta.2 |

- example: fix `custom-provider` example (Antoine du Hamel / #3854)
- example: fix Vue3 example (Antoine du Hamel / #3774)
- @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / #3833)
- example: update CDN example (Antoine du Hamel / #3803)
- @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / #3826)
- @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / #3827)
- @uppy/companion: remove companion provider compat api (Mikael Finstad / #3828)
- @uppy/companion: rewrite code for node >=14 (Mikael Finstad / #3829)
- @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / #3830)
- @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / #3832)
- @uppy/companion: do not use a default upload protocol (Mikael Finstad / #3834)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package              |      Version | Package              |      Version |
| -------------------- | ------------ | -------------------- | ------------ |
| @uppy/companion      | 4.0.0-beta.1 | @uppy/transloadit    | 3.0.0-beta.2 |
| @uppy/locales        | 3.0.0-beta.2 | @uppy/robodog        | 3.0.0-beta.2 |
| @uppy/provider-views | 3.0.0-beta.2 | uppy                 | 3.0.0-beta.2 |

- example: fix `custom-provider` example (Antoine du Hamel / transloadit#3854)
- example: fix Vue3 example (Antoine du Hamel / transloadit#3774)
- @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / transloadit#3833)
- example: update CDN example (Antoine du Hamel / transloadit#3803)
- @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / transloadit#3826)
- @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / transloadit#3827)
- @uppy/companion: remove companion provider compat api (Mikael Finstad / transloadit#3828)
- @uppy/companion: rewrite code for node >=14 (Mikael Finstad / transloadit#3829)
- @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / transloadit#3830)
- @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / transloadit#3832)
- @uppy/companion: do not use a default upload protocol (Mikael Finstad / transloadit#3834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants