New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: update Vue2 example #3802
Conversation
@@ -121,7 +121,8 @@ | |||
"temp-write": "^5.0.0", | |||
"tsd": "^0.17.0", | |||
"typescript": "~4.4", | |||
"verdaccio": "^5.1.1" | |||
"verdaccio": "^5.1.1", | |||
"vue-template-compiler": "workspace:*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why we need this 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the explanation there: https://github.com/transloadit/uppy/pull/3802/files#diff-4bea83be50434c7f99646e7178ae936953bfe18cd00c64066fd67442c8b7aab7R5
If we don't have a vue-template-compiler
package at the root level, the vue-template-compiler
of the Vue2 example will be installed to the root node_modules
dir instead of the examples/vue/node_modules
dir, and because we have Vue 3 installed in the root node_modules
dir, it picks it up instead of the Vue 2 installed in the examples/vue/node_modules
dir. I think that's the fault of this package to not list Vue 2 in its (peer) dependencies: https://github.com/vuejs/vue/blob/dev/packages/vue-template-compiler/package.json
| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | uppy | 3.0.0-beta.1 | @uppy/google-drive | 3.0.0-beta.1 | | @uppy/audio | 1.0.0-beta.1 | @uppy/informer | 3.0.0-beta.1 | | @uppy/box | 2.0.0-beta.1 | @uppy/instagram | 3.0.0-beta.1 | | @uppy/compressor | 1.0.0-beta.1 | @uppy/locales | 3.0.0-beta.1 | | @uppy/drop-target | 2.0.0-beta.1 | @uppy/onedrive | 3.0.0-beta.1 | | @uppy/image-editor | 2.0.0-beta.1 | @uppy/progress-bar | 3.0.0-beta.1 | | @uppy/remote-sources | 1.0.0-beta.1 | @uppy/provider-views | 3.0.0-beta.1 | | @uppy/svelte | 2.0.0-beta.1 | @uppy/react | 3.0.0-beta.1 | | @uppy/vue | 1.0.0-beta.1 | @uppy/redux-dev-tools | 3.0.0-beta.1 | | @uppy/zoom | 2.0.0-beta.1 | @uppy/robodog | 3.0.0-beta.1 | | @uppy/aws-s3 | 3.0.0-beta.1 | @uppy/screen-capture | 3.0.0-beta.1 | | @uppy/aws-s3-multipart | 3.0.0-beta.1 | @uppy/status-bar | 3.0.0-beta.1 | | @uppy/companion-client | 3.0.0-beta.1 | @uppy/store-default | 3.0.0-beta.1 | | @uppy/core | 3.0.0-beta.1 | @uppy/store-redux | 3.0.0-beta.1 | | @uppy/dashboard | 3.0.0-beta.1 | @uppy/thumbnail-generator | 3.0.0-beta.1 | | @uppy/drag-drop | 3.0.0-beta.1 | @uppy/transloadit | 3.0.0-beta.1 | | @uppy/dropbox | 3.0.0-beta.1 | @uppy/tus | 3.0.0-beta.1 | | @uppy/facebook | 3.0.0-beta.1 | @uppy/unsplash | 3.0.0-beta.1 | | @uppy/file-input | 3.0.0-beta.1 | @uppy/url | 3.0.0-beta.1 | | @uppy/form | 3.0.0-beta.1 | @uppy/webcam | 3.0.0-beta.1 | | @uppy/golden-retriever | 3.0.0-beta.1 | @uppy/xhr-upload | 3.0.0-beta.1 | - meta: improve release process for beta branch (Antoine du Hamel / #3809) - uppy: refactor to ESM (Antoine du Hamel / #3807) - @uppy/core,@uppy/dashboard: fix types for some events (Antoine du Hamel / #3812) - example: update Vue2 example (Antoine du Hamel / #3802)
The Vue2 example is now using Vite to improve the DX.