Companion 3 default to no s3 acl #3826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove no longer needed process.env.COMPANION_AWS_DISABLE_ACL
Murderlon
approved these changes
Jun 16, 2022
This was referenced Jul 6, 2022
Closed
Closed
github-actions bot
added a commit
that referenced
this pull request
Jul 6, 2022
| Package | Version | Package | Version | | -------------------- | ------------ | -------------------- | ------------ | | @uppy/companion | 4.0.0-beta.1 | @uppy/transloadit | 3.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.2 | | @uppy/provider-views | 3.0.0-beta.2 | uppy | 3.0.0-beta.2 | - example: fix `custom-provider` example (Antoine du Hamel / #3854) - example: fix Vue3 example (Antoine du Hamel / #3774) - @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / #3833) - example: update CDN example (Antoine du Hamel / #3803) - @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / #3826) - @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / #3827) - @uppy/companion: remove companion provider compat api (Mikael Finstad / #3828) - @uppy/companion: rewrite code for node >=14 (Mikael Finstad / #3829) - @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / #3830) - @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / #3832) - @uppy/companion: do not use a default upload protocol (Mikael Finstad / #3834)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* default to no ACL for s3 and remove no longer needed process.env.COMPANION_AWS_DISABLE_ACL * fix what looks like a bug
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | -------------------- | ------------ | -------------------- | ------------ | | @uppy/companion | 4.0.0-beta.1 | @uppy/transloadit | 3.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.2 | | @uppy/provider-views | 3.0.0-beta.2 | uppy | 3.0.0-beta.2 | - example: fix `custom-provider` example (Antoine du Hamel / transloadit#3854) - example: fix Vue3 example (Antoine du Hamel / transloadit#3774) - @uppy/companion: remove deprecated duplicated metrics (Mikael Finstad / transloadit#3833) - example: update CDN example (Antoine du Hamel / transloadit#3803) - @uppy/companion: Companion 3 default to no s3 acl (Mikael Finstad / transloadit#3826) - @uppy/companion: rewrite companion.app() to return an object (Mikael Finstad / transloadit#3827) - @uppy/companion: remove companion provider compat api (Mikael Finstad / transloadit#3828) - @uppy/companion: rewrite code for node >=14 (Mikael Finstad / transloadit#3829) - @uppy/companion: remove chunkSize backwards compatibility (Mikael Finstad / transloadit#3830) - @uppy/companion: Companion: make `emitSuccess` and `emitError` private (Mikael Finstad / transloadit#3832) - @uppy/companion: do not use a default upload protocol (Mikael Finstad / transloadit#3834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pulled out from #3791
Breaking changes
public-readbut AWS now discourages ACLs).COMPANION_AWS_DISABLE_ACL, will instead only useCOMPANION_AWS_ACL