meta: use node: protocol when using Node.js built-in core modules
#3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, Companion tests failing due to version? |
|
Hum I think it's failing on the |
`node:` protocol is available as of Node.js 14.18.0 LTS. Since we are dropping support for all Node.js versions below that, we can take advantage of this prefix to help differentiate built-in modules from npm modules.
aduh95
force-pushed
the
prefer-node-protocol
branch
from
168d6c9
to
f4fe365
Compare
Murderlon
approved these changes
Jul 15, 2022
mifi
approved these changes
Jul 16, 2022
github-actions bot
added a commit
that referenced
this pull request
Jul 27, 2022
| Package | Version | Package | Version | | ---------------------- | ------------ | ---------------------- | ------------ | | @uppy/aws-s3 | 3.0.0-beta.2 | @uppy/react | 3.0.0-beta.2 | | @uppy/aws-s3-multipart | 3.0.0-beta.2 | @uppy/remote-sources | 1.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.2 | @uppy/store-redux | 3.0.0-beta.2 | | @uppy/compressor | 1.0.0-beta.2 | @uppy/transloadit | 3.0.0-beta.3 | | @uppy/core | 3.0.0-beta.2 | @uppy/webcam | 3.0.0-beta.2 | | @uppy/dashboard | 3.0.0-beta.2 | @uppy/xhr-upload | 3.0.0-beta.2 | | @uppy/image-editor | 2.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.3 | | @uppy/locales | 3.0.0-beta.3 | uppy | 3.0.0-beta.3 | - @uppy/react: Fix exports in propTypes.js to fix website build (Murderlon) - @uppy/dashboard,@uppy/webcam: Add support for `mobileNativeCamera` option to Webcam and Dashboard (Artur Paikin / #3844) - @uppy/aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (Merlijn Vos / #3895) - @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: upgrade `nanoid` to v4 (Antoine du Hamel / #3904) - @uppy/companion: update minimal supported Node.js version in the docs (Antoine du Hamel / #3902) - @uppy/companion: upgrade `redis` to version 4.x (Antoine du Hamel / #3589) - @uppy/companion: remove unnecessary ts-ignores (Mikael Finstad / #3900) - meta: use `node:` protocol when using Node.js built-in core modules (Antoine du Hamel / #3871) - meta: upgrade to Vite v3 (Antoine du Hamel / #3882) - @uppy/companion: remove `COMPANION_S3_GETKEY_SAFE_BEHAVIOR` env variable (Antoine du Hamel / #3869) - meta: fix release script for major beta versions (Antoine du Hamel)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
…ransloadit#3871) `node:` protocol is available as of Node.js 14.18.0 LTS. Since we are dropping support for all Node.js versions below that, we can take advantage of this prefix to help differentiate built-in modules from npm modules.
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ---------------------- | ------------ | ---------------------- | ------------ | | @uppy/aws-s3 | 3.0.0-beta.2 | @uppy/react | 3.0.0-beta.2 | | @uppy/aws-s3-multipart | 3.0.0-beta.2 | @uppy/remote-sources | 1.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.2 | @uppy/store-redux | 3.0.0-beta.2 | | @uppy/compressor | 1.0.0-beta.2 | @uppy/transloadit | 3.0.0-beta.3 | | @uppy/core | 3.0.0-beta.2 | @uppy/webcam | 3.0.0-beta.2 | | @uppy/dashboard | 3.0.0-beta.2 | @uppy/xhr-upload | 3.0.0-beta.2 | | @uppy/image-editor | 2.0.0-beta.2 | @uppy/robodog | 3.0.0-beta.3 | | @uppy/locales | 3.0.0-beta.3 | uppy | 3.0.0-beta.3 | - @uppy/react: Fix exports in propTypes.js to fix website build (Murderlon) - @uppy/dashboard,@uppy/webcam: Add support for `mobileNativeCamera` option to Webcam and Dashboard (Artur Paikin / transloadit#3844) - @uppy/aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (Merlijn Vos / transloadit#3895) - @uppy/aws-s3,@uppy/core,@uppy/dashboard,@uppy/store-redux,@uppy/xhr-upload: upgrade `nanoid` to v4 (Antoine du Hamel / transloadit#3904) - @uppy/companion: update minimal supported Node.js version in the docs (Antoine du Hamel / transloadit#3902) - @uppy/companion: upgrade `redis` to version 4.x (Antoine du Hamel / transloadit#3589) - @uppy/companion: remove unnecessary ts-ignores (Mikael Finstad / transloadit#3900) - meta: use `node:` protocol when using Node.js built-in core modules (Antoine du Hamel / transloadit#3871) - meta: upgrade to Vite v3 (Antoine du Hamel / transloadit#3882) - @uppy/companion: remove `COMPANION_S3_GETKEY_SAFE_BEHAVIOR` env variable (Antoine du Hamel / transloadit#3869) - meta: fix release script for major beta versions (Antoine du Hamel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node:protocol is available as of Node.js 14.18.0 LTS. Since we aredropping support for all Node.js versions below that, we can take
advantage of this prefix to help differentiate built-in modules from npm
modules.