Companion: sort Dropbox response & refactor to async/await

[mifi]

also refactored to async/await

fixes #3580

[Murderlon]

This works too, but I'm sure the Dropbox API supports a query parameter to do it for us. Either way is fine I suppose.

[mifi]

seems like it doesnt: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/list-orderby-api/td-p/337393

[Murderlon]

nit: triple destructering hurts readability

[mifi]

Suggested change

	const [{ body: stats }, { body: { email } }] = responses
	const { body: stats } = responses[0]
	const { body: { email } } = responses[1]

[aduh95]

Suggested change

	}))
	items.sort((a, b) => a.name.localeCompare(b.name, 'en-US', { numeric: true }))
	})).sort((a, b) => a.name.localeCompare(b.name, 'en-US', { numeric: true }))

[mifi]

i think it reads better on a separate line

[aduh95]

I don't, and also it's not immediately obvious that .sort would modify the original array if you're not familiar. I won't push it if that's your preference though.

[aduh95]

Intead, let's pass promise:true when creating the purest instance here

uppy/packages/@uppy/companion/src/server/provider/dropbox/index.js

Line 2 in 7b0db7d

const purest = require('purest')({ request })

[mifi]

not sure i follow

[aduh95]

purest supports promises out of the box, let's use that instead of promisifying their API over and over again.

[mifi]

i cannot find any promise:true option documented anywhere. are you sure it's for purest?

[mifi]

ahh, now i see, v4 uses promises by default. maybe we can try to upgrade to purest v4. or v3 uses require('purest')({ request, promise: Promise })

[aduh95]

Oh ok, I've seen the promise option and assumed it was a boolean. Yes, let's upgrade, they've dropped support for Node.js 10.x but have we on 3.x.

[aduh95]

If we're not upgrading or migrating just yet, can we use the promise option?

[aduh95]

also refactored to async/await

Likely a breaking change, right? It might be safer to land on 3.x only.

[mifi]

Likely a breaking change, right? It might be safer to land on 3.x only.

why is it a breaking change? I don't think anyone is supposed to subclass Dropbox if that's what you're thinking of

[aduh95]

Likely a breaking change, right? It might be safer to land on 3.x only.

why is it a breaking change? I don't think anyone is supposed to subclass Dropbox if that's what you're thinking of

It's not because they're not suppose to do it that they're not doing it. Anyways, v4 release is so close, why not take a prudent approach and call it a breaking change just in case?