Fix all breaking todo comments for 3.0 #3907

Murderlon · 2022-07-26T10:37:12Z

Warning
This PR requires careful review and testing.

Description below serves as reference for the changelog and migration guide.

Breaking changes

@uppy/aws/s3-multipart: remove client getter and setter.
- reason: internal usage only
- migrate: use exposed options only
@uppy/core: remove AggregateError polyfill
- reason: should be polyfilled by the user
- migrate: install AggregateError polyfill or use core-js
@uppy/core: remove reset() method
- reason: it's a duplicate of cancelAll, but with a less intention revealing name
- migrate: use cancelAll
@uppy/core: remove backwards compatible exports (static properties on Uppy)
- reason: transition to ESM
- migrate: import the Uppy class by default and/or use named exports for everything else.
@uppy/react: don't expose validProps
- reason: internal only
- migrate: do not depend on this
@uppy/store-redux: remove backwards compatible exports (static properties on ReduxStore)
- reason: transition to ESM
- migrate: use named imports
@uppy/thumbnail-generator: remove rotateImage, protect, and canvasToBlob from prototype.
- reason: internal only
- migrate: don't depend on this

aduh95 · 2022-07-26T10:50:50Z

It breaks the e2e tests.
Can we land this as separate commits so it appears more clearly on the CHANGELOG?

Murderlon · 2022-07-26T11:08:12Z

Can we land this as separate commits so it appears more clearly on the CHANGELOG?

I'll manually edit the changelog to match it based on what I wrote here.

packages/@uppy/companion/src/server/controllers/url.js

packages/@uppy/react/src/Dashboard.js

* 3.x: (32 commits) @uppy/screen-capture: fix TODOs (#3930) @uppy/status-bar: rename internal modules (#3929) @uppy/transloadit: remove static properties in favor of exports (#3927) @uppy/informer: simplify `render` method (#3931) @uppy/url: remove private methods from public API (#3934) @uppy/dashboard: change `copyToClipboard` signature (#3933) @uppy/drop-target: remove `isFileTransfer` from the public API (#3932) meta: improve beta release script Release: uppy@3.0.0-beta.3 (#3918) Release: uppy@2.13.1 (#3916) Fix exports in propTypes.js to fix website build @uppy/compressor: fix upload causing meta name to reset (#3890) @uppy/transloadit: cancel assemblies when all its files have been removed (#3893) Add retries for flaky e2e test (#3915) Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914) webcam: Add support for mobileNativeCamera option to Webcam and Dashboard (#3844) aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (#3895) Add missing type for retry-all event (#3901) Companion app type (#3899) e2e: upgrade to Cypress 10 (#3896) ...

website/src/docs/core.md

packages/@uppy/core/src/index.js

arturi · 2022-08-02T22:43:38Z

When Dashboard is resized, I get this:

arturi · 2022-08-02T22:49:40Z

packages/@uppy/companion/src/server/controllers/url.js

@@ -93,7 +93,6 @@ const meta = async (req, res) => {
    return res.json(urlMeta)
  } catch (err) {
    logger.error(err, 'controller.url.meta.error', req.id)
-    // @todo send more meaningful error message and status code to client if possible


Do we give up on sending a more meaningful error message?

We don't want to expose information to the client: #3907 (comment)

Murderlon · 2022-08-03T08:49:54Z

When Dashboard is resized, I get this:

I can't reproduce this 🤔

mifi · 2022-08-03T12:56:25Z

When Dashboard is resized, I get this:

I'm also getting this when trying to download/upload a file using companion

TransitionGroup.js:268 Uncaught (in promise) ReferenceError: key is not defined
    at TransitionGroup.js:268:33
    at Array.map (<anonymous>)
    at TransitionGroup.render (TransitionGroup.js:267:70)
    at j (index.js:181:12)
    at w (children.js:137:3)
    at L (index.js:404:4)
    at j (index.js:232:20)
    at w (children.js:137:3)
    at L (index.js:404:4)
    at j (index.js:232:20)

but I'm not on this PR #3907, I'm on 3.x

Update: seems unstable. I tried again and did not get it on upload. I got it after upload failed now.

Murderlon · 2022-08-03T13:08:23Z

but I'm not on this PR #3907, I'm on 3.x

Update: seems unstable. I tried again and did not get it on upload. I got it after upload failed now.

I just tested on 3.x branch, with imports from google drive on local companion and resizing, but I don't get these errors?

mifi · 2022-08-03T13:12:29Z

I found a way to reproduce it:

try to comment out this line

uppy/packages/@uppy/companion/src/server/helpers/utils.js

Line 155 in 8f72280

resolve(response)

that way the upload/download will time out. after timeout, uppy seems to trigger this error when the upload transitions into the failed state

arturi · 2022-08-03T14:19:41Z

It's been fixed by @aduh95 in 5fca617, I believe.

Murderlon · 2022-08-03T14:31:29Z

Could be because I still can't reproduce it. If there are no other issues @arturi, feel free to approve so we can merge and finish the migration guide :)

| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | @uppy/audio | 1.0.0-beta.2 | @uppy/progress-bar | 3.0.0-beta.2 | | @uppy/aws-s3 | 3.0.0-beta.3 | @uppy/provider-views | 3.0.0-beta.3 | | @uppy/aws-s3-multipart | 3.0.0-beta.4 | @uppy/react | 3.0.0-beta.4 | | @uppy/box | 2.0.0-beta.2 | @uppy/redux-dev-tools | 3.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.4 | @uppy/remote-sources | 1.0.0-beta.4 | | @uppy/companion-client | 3.0.0-beta.2 | @uppy/screen-capture | 3.0.0-beta.3 | | @uppy/compressor | 1.0.0-beta.3 | @uppy/status-bar | 3.0.0-beta.3 | | @uppy/core | 3.0.0-beta.4 | @uppy/store-default | 3.0.0-beta.3 | | @uppy/dashboard | 3.0.0-beta.4 | @uppy/store-redux | 3.0.0-beta.3 | | @uppy/drag-drop | 3.0.0-beta.2 | @uppy/svelte | 2.0.0-beta.2 | | @uppy/drop-target | 2.0.0-beta.3 | @uppy/thumbnail-generator | 3.0.0-beta.2 | | @uppy/dropbox | 3.0.0-beta.2 | @uppy/transloadit | 3.0.0-beta.5 | | @uppy/facebook | 3.0.0-beta.2 | @uppy/tus | 3.0.0-beta.3 | | @uppy/file-input | 3.0.0-beta.2 | @uppy/unsplash | 3.0.0-beta.2 | | @uppy/form | 3.0.0-beta.2 | @uppy/url | 3.0.0-beta.3 | | @uppy/golden-retriever | 3.0.0-beta.2 | @uppy/utils | 5.0.0-beta.1 | | @uppy/google-drive | 3.0.0-beta.2 | @uppy/vue | 1.0.0-beta.2 | | @uppy/image-editor | 2.0.0-beta.3 | @uppy/webcam | 3.0.0-beta.3 | | @uppy/informer | 3.0.0-beta.3 | @uppy/xhr-upload | 3.0.0-beta.3 | | @uppy/instagram | 3.0.0-beta.2 | @uppy/zoom | 2.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.4 | uppy | 3.0.0-beta.5 | | @uppy/onedrive | 3.0.0-beta.2 | | | - meta: prepare release workflow for beta versions (Antoine du Hamel) - @uppy/provider-views: Reset filter input correctly in provider views (Merlijn Vos / #3978) - @uppy/aws-s3-multipart: Fix when using Companion (Merlijn Vos / #3969) - @uppy/companion: Companion: bring back default upload protocol (Mikael Finstad / #3967) - meta: Update CONTRIBUTING.md (Mikael Finstad / #3966) - meta: fix contributing link (Mikael Finstad / #3968) - @uppy/companion: enforce usage of uploadUrls (Mikael Finstad / #3965) - @uppy/utils: Fix webp mimetype (Merlijn Vos / #3961) - @uppy/locales: Add compressor string translation to Japanese locale (kenken / #3963) - meta: Fix statement about cropping images in README.md (Mikael Finstad / #3964) - @uppy/aws-s3-multipart: Fix race condition in `#uploadParts` (Morgan Zolob / #3955) - @uppy/provider-views: core validateRestrictions: return error directly vs the result/reason obj (Artur Paikin / #3951) - @uppy/aws-s3: Export AwsS3UploadParameters & AwsS3Options interfaces (Antonina Vertsinskaya / #3956) - website: convert all website examples to ESM (Antoine du Hamel / #3957) - @uppy/companion: fix crash if redis disconnects (Mikael Finstad / #3954) - @uppy/companion: upgrade `ws` version (Antoine du Hamel / #3949) - @uppy/companion: sort Dropbox response & refactor to async/await (Mikael Finstad / #3897) - @uppy/utils: modernize `getDroppedFiles` (Antoine du Hamel / #3534) - @uppy/companion: fix default getKey for non-standalone too (Mikael Finstad / #3945) - @uppy/aws-s3-multipart: ignore exception inside `abortMultipartUpload` (Antoine du Hamel / #3950) - @uppy/companion: remove `isobject` from dependencies (Antoine du Hamel / #3948) - @uppy/compressor: Fix Compressor being broken when no name is in the compressed blob (Artur Paikin / #3947) - @uppy/core,@uppy/react: Fix all breaking todo comments for 3.0 (Merlijn Vos / #3907) - @uppy/companion: show deprecation message when using legacy s3 options (Antoine du Hamel / #3944) - example: fix aws-companion example (Antoine du Hamel / #3850)

- `@uppy/aws/s3-multipart`: remove `client` getter and setter. - reason: internal usage only - migrate: use exposed options only - `@uppy/core`: remove `AggregateError` polyfill - reason: [should be polyfilled by the user](transloadit#3532 (comment)) - migrate: install `AggregateError` polyfill or use `core-js` - `@uppy/core`: remove `reset()` method - reason: it's a duplicate of `cancelAll`, but with a less intention revealing name - migrate: use `cancelAll` - `@uppy/core`: remove backwards compatible exports (static properties on `Uppy`) - reason: transition to ESM - migrate: import the `Uppy` class by default and/or use named exports for everything else. - `@uppy/react`: don't expose `validProps` - reason: internal only - migrate: do not depend on this - `@uppy/store-redux`: remove backwards compatible exports (static properties on `ReduxStore`) - reason: transition to ESM - migrate: use named imports - `@uppy/thumbnail-generator`: remove `rotateImage`, `protect`, and `canvasToBlob` from prototype. - reason: internal only - migrate: don't depend on this

| Package | Version | Package | Version | | ------------------------- | ------------ | ------------------------- | ------------ | | @uppy/audio | 1.0.0-beta.2 | @uppy/progress-bar | 3.0.0-beta.2 | | @uppy/aws-s3 | 3.0.0-beta.3 | @uppy/provider-views | 3.0.0-beta.3 | | @uppy/aws-s3-multipart | 3.0.0-beta.4 | @uppy/react | 3.0.0-beta.4 | | @uppy/box | 2.0.0-beta.2 | @uppy/redux-dev-tools | 3.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.4 | @uppy/remote-sources | 1.0.0-beta.4 | | @uppy/companion-client | 3.0.0-beta.2 | @uppy/screen-capture | 3.0.0-beta.3 | | @uppy/compressor | 1.0.0-beta.3 | @uppy/status-bar | 3.0.0-beta.3 | | @uppy/core | 3.0.0-beta.4 | @uppy/store-default | 3.0.0-beta.3 | | @uppy/dashboard | 3.0.0-beta.4 | @uppy/store-redux | 3.0.0-beta.3 | | @uppy/drag-drop | 3.0.0-beta.2 | @uppy/svelte | 2.0.0-beta.2 | | @uppy/drop-target | 2.0.0-beta.3 | @uppy/thumbnail-generator | 3.0.0-beta.2 | | @uppy/dropbox | 3.0.0-beta.2 | @uppy/transloadit | 3.0.0-beta.5 | | @uppy/facebook | 3.0.0-beta.2 | @uppy/tus | 3.0.0-beta.3 | | @uppy/file-input | 3.0.0-beta.2 | @uppy/unsplash | 3.0.0-beta.2 | | @uppy/form | 3.0.0-beta.2 | @uppy/url | 3.0.0-beta.3 | | @uppy/golden-retriever | 3.0.0-beta.2 | @uppy/utils | 5.0.0-beta.1 | | @uppy/google-drive | 3.0.0-beta.2 | @uppy/vue | 1.0.0-beta.2 | | @uppy/image-editor | 2.0.0-beta.3 | @uppy/webcam | 3.0.0-beta.3 | | @uppy/informer | 3.0.0-beta.3 | @uppy/xhr-upload | 3.0.0-beta.3 | | @uppy/instagram | 3.0.0-beta.2 | @uppy/zoom | 2.0.0-beta.2 | | @uppy/locales | 3.0.0-beta.4 | uppy | 3.0.0-beta.5 | | @uppy/onedrive | 3.0.0-beta.2 | | | - meta: prepare release workflow for beta versions (Antoine du Hamel) - @uppy/provider-views: Reset filter input correctly in provider views (Merlijn Vos / transloadit#3978) - @uppy/aws-s3-multipart: Fix when using Companion (Merlijn Vos / transloadit#3969) - @uppy/companion: Companion: bring back default upload protocol (Mikael Finstad / transloadit#3967) - meta: Update CONTRIBUTING.md (Mikael Finstad / transloadit#3966) - meta: fix contributing link (Mikael Finstad / transloadit#3968) - @uppy/companion: enforce usage of uploadUrls (Mikael Finstad / transloadit#3965) - @uppy/utils: Fix webp mimetype (Merlijn Vos / transloadit#3961) - @uppy/locales: Add compressor string translation to Japanese locale (kenken / transloadit#3963) - meta: Fix statement about cropping images in README.md (Mikael Finstad / transloadit#3964) - @uppy/aws-s3-multipart: Fix race condition in `#uploadParts` (Morgan Zolob / transloadit#3955) - @uppy/provider-views: core validateRestrictions: return error directly vs the result/reason obj (Artur Paikin / transloadit#3951) - @uppy/aws-s3: Export AwsS3UploadParameters & AwsS3Options interfaces (Antonina Vertsinskaya / transloadit#3956) - website: convert all website examples to ESM (Antoine du Hamel / transloadit#3957) - @uppy/companion: fix crash if redis disconnects (Mikael Finstad / transloadit#3954) - @uppy/companion: upgrade `ws` version (Antoine du Hamel / transloadit#3949) - @uppy/companion: sort Dropbox response & refactor to async/await (Mikael Finstad / transloadit#3897) - @uppy/utils: modernize `getDroppedFiles` (Antoine du Hamel / transloadit#3534) - @uppy/companion: fix default getKey for non-standalone too (Mikael Finstad / transloadit#3945) - @uppy/aws-s3-multipart: ignore exception inside `abortMultipartUpload` (Antoine du Hamel / transloadit#3950) - @uppy/companion: remove `isobject` from dependencies (Antoine du Hamel / transloadit#3948) - @uppy/compressor: Fix Compressor being broken when no name is in the compressed blob (Artur Paikin / transloadit#3947) - @uppy/core,@uppy/react: Fix all breaking todo comments for 3.0 (Merlijn Vos / transloadit#3907) - @uppy/companion: show deprecation message when using legacy s3 options (Antoine du Hamel / transloadit#3944) - example: fix aws-companion example (Antoine du Hamel / transloadit#3850)

Fix all breaking todos

d8803d6

Murderlon added the 3.0 label Jul 26, 2022

Murderlon requested review from mifi, arturi and aduh95 July 26, 2022 10:37

Add missing export in core/src/index.js

cf25ee5

mifi reviewed Jul 26, 2022

View reviewed changes

packages/@uppy/companion/src/server/controllers/url.js Outdated Show resolved Hide resolved

packages/@uppy/companion/src/server/controllers/url.js Outdated Show resolved Hide resolved

packages/@uppy/react/src/Dashboard.js Outdated Show resolved Hide resolved

Revert response changes in companion/src/server/controllers/url.js

33619df

Murderlon mentioned this pull request Jul 27, 2022

Add migration guide for Uppy 3.x, Companion 4.x, and Robodog #3913

Merged

Murderlon added 2 commits August 2, 2022 16:04

Remove Symbol for props, pass props instead

b77cb0c

aduh95 reviewed Aug 2, 2022

View reviewed changes

website/src/docs/core.md Outdated Show resolved Hide resolved

Bring back cancelAll docs

8f9e72c

aduh95 approved these changes Aug 2, 2022

View reviewed changes

mifi approved these changes Aug 2, 2022

View reviewed changes

arturi reviewed Aug 2, 2022

View reviewed changes

packages/@uppy/core/src/index.js Show resolved Hide resolved

arturi reviewed Aug 2, 2022

View reviewed changes

Fix debugLogger

706186b

arturi self-requested a review August 3, 2022 17:24

arturi approved these changes Aug 3, 2022

View reviewed changes

Murderlon merged commit 9a213b5 into 3.x Aug 3, 2022

Murderlon deleted the breaking-todos branch August 3, 2022 18:07

This was referenced Aug 16, 2022

Release: uppy@3.0.0-beta.5 #3990

Closed

Release: uppy@3.0.0-beta.5 #3991

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all breaking todo comments for 3.0 #3907

Fix all breaking todo comments for 3.0 #3907

Murderlon commented Jul 26, 2022 •

edited

aduh95 commented Jul 26, 2022

Murderlon commented Jul 26, 2022

arturi commented Aug 2, 2022

arturi Aug 2, 2022

Murderlon Aug 3, 2022

Murderlon commented Aug 3, 2022

mifi commented Aug 3, 2022 •

edited

Murderlon commented Aug 3, 2022

mifi commented Aug 3, 2022

arturi commented Aug 3, 2022

Murderlon commented Aug 3, 2022

Navigation Menu

Fix all breaking todo comments for 3.0 #3907

Fix all breaking todo comments for 3.0 #3907

Conversation

Murderlon commented Jul 26, 2022 • edited

Breaking changes

aduh95 commented Jul 26, 2022

Murderlon commented Jul 26, 2022

arturi commented Aug 2, 2022

arturi Aug 2, 2022

Choose a reason for hiding this comment

Murderlon Aug 3, 2022

Choose a reason for hiding this comment

Murderlon commented Aug 3, 2022

mifi commented Aug 3, 2022 • edited

Murderlon commented Aug 3, 2022

mifi commented Aug 3, 2022

arturi commented Aug 3, 2022

Murderlon commented Aug 3, 2022

Murderlon commented Jul 26, 2022 •

edited

mifi commented Aug 3, 2022 •

edited