Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/status-bar: rename internal modules #3929

Merged
merged 2 commits into from Aug 2, 2022
Merged

@uppy/status-bar: rename internal modules #3929

merged 2 commits into from Aug 2, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Aug 1, 2022

No description provided.

@aduh95 aduh95 added the 3.0 label Aug 1, 2022
Murderlon
Murderlon reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large diff so it's hard to see all the changes. Statusbar is very error prone with refactors, as I experiences before. So probably best to keep it to just moving things around, rather than refactoring a lot, which seems to be the case.

@aduh95
Copy link
Member Author

aduh95 commented Aug 2, 2022

It's unfortunate that GitHub shows a large diff, because it's actually a very simple change x) Let me try to split that in several commits.

@aduh95 aduh95 requested a review from Murderlon August 2, 2022 11:23
@aduh95
Copy link
Member Author

aduh95 commented Aug 2, 2022

Please review the commits one by one, as the diff is much simpler.

Murderlon
Murderlon approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that helped

@aduh95 aduh95 merged commit dc7ad4b into transloadit:3.x Aug 2, 2022
@aduh95 aduh95 deleted the status-bar-breaking-todo branch August 2, 2022 12:53
Murderlon added a commit that referenced this pull request Aug 2, 2022
@Murderlon
Merge branch '3.x' into breaking-todos
ee4de99 
* 3.x: (32 commits)
  @uppy/screen-capture: fix TODOs (#3930)
  @uppy/status-bar: rename internal modules (#3929)
  @uppy/transloadit: remove static properties in favor of exports (#3927)
  @uppy/informer: simplify `render` method (#3931)
  @uppy/url: remove private methods from public API (#3934)
  @uppy/dashboard: change `copyToClipboard` signature (#3933)
  @uppy/drop-target: remove `isFileTransfer` from the public API (#3932)
  meta: improve beta release script
  Release: uppy@3.0.0-beta.3 (#3918)
  Release: uppy@2.13.1 (#3916)
  Fix exports in propTypes.js to fix website build
  @uppy/compressor: fix upload causing meta name to reset (#3890)
  @uppy/transloadit: cancel assemblies when all its files have been removed (#3893)
  Add retries for flaky e2e test (#3915)
  Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914)
  webcam: Add support for mobileNativeCamera option to Webcam and Dashboard (#3844)
  aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (#3895)
  Add missing type for retry-all event (#3901)
  Companion app type (#3899)
  e2e: upgrade to Cypress 10 (#3896)
  ...
@github-actions github-actions bot mentioned this pull request Aug 3, 2022
Merged
github-actions bot added a commit that referenced this pull request Aug 3, 2022
@github-actions
Release: uppy@3.0.0-beta.4 (#3943)
2b87253 
| Package                |      Version | Package                |      Version |
| ---------------------- | ------------ | ---------------------- | ------------ |
| @uppy/aws-s3-multipart | 3.0.0-beta.3 | @uppy/screen-capture   | 3.0.0-beta.2 |
| @uppy/companion        | 4.0.0-beta.3 | @uppy/status-bar       | 3.0.0-beta.2 |
| @uppy/core             | 3.0.0-beta.3 | @uppy/store-default    | 3.0.0-beta.2 |
| @uppy/dashboard        | 3.0.0-beta.3 | @uppy/transloadit      | 3.0.0-beta.4 |
| @uppy/drop-target      | 2.0.0-beta.2 | @uppy/tus              | 3.0.0-beta.2 |
| @uppy/informer         | 3.0.0-beta.2 | @uppy/url              | 3.0.0-beta.2 |
| @uppy/react            | 3.0.0-beta.3 | @uppy/robodog          | 3.0.0-beta.4 |
| @uppy/remote-sources   | 1.0.0-beta.3 | uppy                   | 3.0.0-beta.4 |

- @uppy/companion,@uppy/tus: Upgrade tus-js-client to 3.0.0 (Merlijn Vos / #3942)
- meta: fix release script (Antoine du Hamel)
- @uppy/aws-s3-multipart: Correctly handle errors for `prepareUploadParts` (Merlijn Vos / #3912)
- @uppy/store-default: export the class, don't expose `.callbacks` (Antoine du Hamel / #3928)
- @uppy/remote-sources: do not rely on `.name` property (Antoine du Hamel / #3941)
- @uppy/screen-capture: fix TODOs (Antoine du Hamel / #3930)
- @uppy/status-bar: rename internal modules (Antoine du Hamel / #3929)
- @uppy/transloadit: remove static properties in favor of exports (Antoine du Hamel / #3927)
- @uppy/informer: simplify `render` method (Antoine du Hamel / #3931)
- @uppy/url: remove private methods from public API (Antoine du Hamel / #3934)
- @uppy/dashboard: change `copyToClipboard` signature (Antoine du Hamel / #3933)
- @uppy/drop-target: remove `isFileTransfer` from the public API (Antoine du Hamel / #3932)
- meta: improve beta release script (Antoine du Hamel)




| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/transloadit |   2.3.6 | @uppy/robodog     |   2.9.2 |
| @uppy/tus         |   2.4.2 | uppy              |  2.13.2 |

- @uppy/transloadit: send `assembly-cancelled` only once (Antoine du Hamel / #3937)
- meta: `keepNames` in bundle (Antoine du Hamel / #3926)
- meta: e2e: fix Transloadit test suite with Cypress 10 (Antoine du Hamel / #3936)
- meta: Bump guzzlehttp/guzzle from 7.4.1 to 7.4.5 in /examples/aws-presigned-url (dependabot[bot] / #3842)
- @uppy/tus: fix dependencies (Antoine du Hamel / #3923)
- meta: doc: fix linter failure in `image-editor.md` (Antoine du Hamel / #3924)
- meta: doc: Fix typo in image-editor.md (Ikko Ashimine / #3921)
- website: Docs and header fix (Artur Paikin / #3920)
Murderlon added a commit that referenced this pull request Aug 3, 2022
@Murderlon
Merge branch '3.x' into migration-guide
04efa23 
* 3.x: (30 commits)
  @uppy/screen-capture: fix TODOs (#3930)
  @uppy/status-bar: rename internal modules (#3929)
  @uppy/transloadit: remove static properties in favor of exports (#3927)
  @uppy/informer: simplify `render` method (#3931)
  @uppy/url: remove private methods from public API (#3934)
  @uppy/dashboard: change `copyToClipboard` signature (#3933)
  @uppy/drop-target: remove `isFileTransfer` from the public API (#3932)
  meta: improve beta release script
  Release: uppy@3.0.0-beta.3 (#3918)
  Release: uppy@2.13.1 (#3916)
  Fix exports in propTypes.js to fix website build
  @uppy/compressor: fix upload causing meta name to reset (#3890)
  @uppy/transloadit: cancel assemblies when all its files have been removed (#3893)
  Add retries for flaky e2e test (#3915)
  Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914)
  Add missing type for retry-all event (#3901)
  Companion app type (#3899)
  e2e: upgrade to Cypress 10 (#3896)
  Fix website build
  Create new issue templates (#3879)
  ...
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@github-actions
Release: uppy@3.0.0-beta.4 (transloadit#3943)
51fac3b 
| Package                |      Version | Package                |      Version |
| ---------------------- | ------------ | ---------------------- | ------------ |
| @uppy/aws-s3-multipart | 3.0.0-beta.3 | @uppy/screen-capture   | 3.0.0-beta.2 |
| @uppy/companion        | 4.0.0-beta.3 | @uppy/status-bar       | 3.0.0-beta.2 |
| @uppy/core             | 3.0.0-beta.3 | @uppy/store-default    | 3.0.0-beta.2 |
| @uppy/dashboard        | 3.0.0-beta.3 | @uppy/transloadit      | 3.0.0-beta.4 |
| @uppy/drop-target      | 2.0.0-beta.2 | @uppy/tus              | 3.0.0-beta.2 |
| @uppy/informer         | 3.0.0-beta.2 | @uppy/url              | 3.0.0-beta.2 |
| @uppy/react            | 3.0.0-beta.3 | @uppy/robodog          | 3.0.0-beta.4 |
| @uppy/remote-sources   | 1.0.0-beta.3 | uppy                   | 3.0.0-beta.4 |

- @uppy/companion,@uppy/tus: Upgrade tus-js-client to 3.0.0 (Merlijn Vos / transloadit#3942)
- meta: fix release script (Antoine du Hamel)
- @uppy/aws-s3-multipart: Correctly handle errors for `prepareUploadParts` (Merlijn Vos / transloadit#3912)
- @uppy/store-default: export the class, don't expose `.callbacks` (Antoine du Hamel / transloadit#3928)
- @uppy/remote-sources: do not rely on `.name` property (Antoine du Hamel / transloadit#3941)
- @uppy/screen-capture: fix TODOs (Antoine du Hamel / transloadit#3930)
- @uppy/status-bar: rename internal modules (Antoine du Hamel / transloadit#3929)
- @uppy/transloadit: remove static properties in favor of exports (Antoine du Hamel / transloadit#3927)
- @uppy/informer: simplify `render` method (Antoine du Hamel / transloadit#3931)
- @uppy/url: remove private methods from public API (Antoine du Hamel / transloadit#3934)
- @uppy/dashboard: change `copyToClipboard` signature (Antoine du Hamel / transloadit#3933)
- @uppy/drop-target: remove `isFileTransfer` from the public API (Antoine du Hamel / transloadit#3932)
- meta: improve beta release script (Antoine du Hamel)




| Package           | Version | Package           | Version |
| ----------------- | ------- | ----------------- | ------- |
| @uppy/transloadit |   2.3.6 | @uppy/robodog     |   2.9.2 |
| @uppy/tus         |   2.4.2 | uppy              |  2.13.2 |

- @uppy/transloadit: send `assembly-cancelled` only once (Antoine du Hamel / transloadit#3937)
- meta: `keepNames` in bundle (Antoine du Hamel / transloadit#3926)
- meta: e2e: fix Transloadit test suite with Cypress 10 (Antoine du Hamel / transloadit#3936)
- meta: Bump guzzlehttp/guzzle from 7.4.1 to 7.4.5 in /examples/aws-presigned-url (dependabot[bot] / transloadit#3842)
- @uppy/tus: fix dependencies (Antoine du Hamel / transloadit#3923)
- meta: doc: fix linter failure in `image-editor.md` (Antoine du Hamel / transloadit#3924)
- meta: doc: Fix typo in image-editor.md (Ikko Ashimine / transloadit#3921)
- website: Docs and header fix (Artur Paikin / transloadit#3920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
pending end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aduh95 @Murderlon