@uppy/informer: simplify render method
#3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturi
reviewed
Aug 1, 2022
| @@ -264,17 +264,10 @@ class TransitionGroup extends Component { | |||
| render ({ childFactory, transitionLeave, transitionName, transitionAppear, transitionEnter, transitionLeaveTimeout, transitionEnterTimeout, transitionAppearTimeout, component, ...props }, { children }) { | |||
| // TODO: we could get rid of the need for the wrapper node | |||
There was a problem hiding this comment.
But we are not solving / getting rid of the todo?
There was a problem hiding this comment.
My change has nothing to do with the TODO, the TODO comes from https://github.com/developit/preact-transition-group/blob/f4ad5e3121729819aa3670edb79388036fb60ebc/src/TransitionGroup.js#L199, it was written by folks more informed than I am, I'm too afraid to touch it at this point.
Murderlon
approved these changes
Aug 2, 2022
arturi
approved these changes
Aug 2, 2022
Murderlon
added a commit
that referenced
this pull request
Aug 2, 2022
* 3.x: (32 commits) @uppy/screen-capture: fix TODOs (#3930) @uppy/status-bar: rename internal modules (#3929) @uppy/transloadit: remove static properties in favor of exports (#3927) @uppy/informer: simplify `render` method (#3931) @uppy/url: remove private methods from public API (#3934) @uppy/dashboard: change `copyToClipboard` signature (#3933) @uppy/drop-target: remove `isFileTransfer` from the public API (#3932) meta: improve beta release script Release: uppy@3.0.0-beta.3 (#3918) Release: uppy@2.13.1 (#3916) Fix exports in propTypes.js to fix website build @uppy/compressor: fix upload causing meta name to reset (#3890) @uppy/transloadit: cancel assemblies when all its files have been removed (#3893) Add retries for flaky e2e test (#3915) Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914) webcam: Add support for mobileNativeCamera option to Webcam and Dashboard (#3844) aws-s3-multipart: make `headers` part indexed too in `prepareUploadParts` (#3895) Add missing type for retry-all event (#3901) Companion app type (#3899) e2e: upgrade to Cypress 10 (#3896) ...
arturi
reviewed
Aug 3, 2022
| } | ||
| } | ||
| } | ||
| const childrenToRender = Object.values(children).filter(Boolean).map(child => { |
There was a problem hiding this comment.
Lost the key here somewhere.
There was a problem hiding this comment.
I think I have a duplicate at my place, let me take a look.
There was a problem hiding this comment.
Fixed in 5fca617, sorry for the trouble.
aduh95
added a commit
that referenced
this pull request
Aug 3, 2022
github-actions bot
added a commit
that referenced
this pull request
Aug 3, 2022
| Package | Version | Package | Version | | ---------------------- | ------------ | ---------------------- | ------------ | | @uppy/aws-s3-multipart | 3.0.0-beta.3 | @uppy/screen-capture | 3.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.3 | @uppy/status-bar | 3.0.0-beta.2 | | @uppy/core | 3.0.0-beta.3 | @uppy/store-default | 3.0.0-beta.2 | | @uppy/dashboard | 3.0.0-beta.3 | @uppy/transloadit | 3.0.0-beta.4 | | @uppy/drop-target | 2.0.0-beta.2 | @uppy/tus | 3.0.0-beta.2 | | @uppy/informer | 3.0.0-beta.2 | @uppy/url | 3.0.0-beta.2 | | @uppy/react | 3.0.0-beta.3 | @uppy/robodog | 3.0.0-beta.4 | | @uppy/remote-sources | 1.0.0-beta.3 | uppy | 3.0.0-beta.4 | - @uppy/companion,@uppy/tus: Upgrade tus-js-client to 3.0.0 (Merlijn Vos / #3942) - meta: fix release script (Antoine du Hamel) - @uppy/aws-s3-multipart: Correctly handle errors for `prepareUploadParts` (Merlijn Vos / #3912) - @uppy/store-default: export the class, don't expose `.callbacks` (Antoine du Hamel / #3928) - @uppy/remote-sources: do not rely on `.name` property (Antoine du Hamel / #3941) - @uppy/screen-capture: fix TODOs (Antoine du Hamel / #3930) - @uppy/status-bar: rename internal modules (Antoine du Hamel / #3929) - @uppy/transloadit: remove static properties in favor of exports (Antoine du Hamel / #3927) - @uppy/informer: simplify `render` method (Antoine du Hamel / #3931) - @uppy/url: remove private methods from public API (Antoine du Hamel / #3934) - @uppy/dashboard: change `copyToClipboard` signature (Antoine du Hamel / #3933) - @uppy/drop-target: remove `isFileTransfer` from the public API (Antoine du Hamel / #3932) - meta: improve beta release script (Antoine du Hamel) | Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/transloadit | 2.3.6 | @uppy/robodog | 2.9.2 | | @uppy/tus | 2.4.2 | uppy | 2.13.2 | - @uppy/transloadit: send `assembly-cancelled` only once (Antoine du Hamel / #3937) - meta: `keepNames` in bundle (Antoine du Hamel / #3926) - meta: e2e: fix Transloadit test suite with Cypress 10 (Antoine du Hamel / #3936) - meta: Bump guzzlehttp/guzzle from 7.4.1 to 7.4.5 in /examples/aws-presigned-url (dependabot[bot] / #3842) - @uppy/tus: fix dependencies (Antoine du Hamel / #3923) - meta: doc: fix linter failure in `image-editor.md` (Antoine du Hamel / #3924) - meta: doc: Fix typo in image-editor.md (Ikko Ashimine / #3921) - website: Docs and header fix (Artur Paikin / #3920)
Murderlon
added a commit
that referenced
this pull request
Aug 3, 2022
* 3.x: (30 commits) @uppy/screen-capture: fix TODOs (#3930) @uppy/status-bar: rename internal modules (#3929) @uppy/transloadit: remove static properties in favor of exports (#3927) @uppy/informer: simplify `render` method (#3931) @uppy/url: remove private methods from public API (#3934) @uppy/dashboard: change `copyToClipboard` signature (#3933) @uppy/drop-target: remove `isFileTransfer` from the public API (#3932) meta: improve beta release script Release: uppy@3.0.0-beta.3 (#3918) Release: uppy@2.13.1 (#3916) Fix exports in propTypes.js to fix website build @uppy/compressor: fix upload causing meta name to reset (#3890) @uppy/transloadit: cancel assemblies when all its files have been removed (#3893) Add retries for flaky e2e test (#3915) Fix `uppy.close()` crashes when remote-sources or image-editor is installed (#3914) Add missing type for retry-all event (#3901) Companion app type (#3899) e2e: upgrade to Cypress 10 (#3896) Fix website build Create new issue templates (#3879) ...
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ---------------------- | ------------ | ---------------------- | ------------ | | @uppy/aws-s3-multipart | 3.0.0-beta.3 | @uppy/screen-capture | 3.0.0-beta.2 | | @uppy/companion | 4.0.0-beta.3 | @uppy/status-bar | 3.0.0-beta.2 | | @uppy/core | 3.0.0-beta.3 | @uppy/store-default | 3.0.0-beta.2 | | @uppy/dashboard | 3.0.0-beta.3 | @uppy/transloadit | 3.0.0-beta.4 | | @uppy/drop-target | 2.0.0-beta.2 | @uppy/tus | 3.0.0-beta.2 | | @uppy/informer | 3.0.0-beta.2 | @uppy/url | 3.0.0-beta.2 | | @uppy/react | 3.0.0-beta.3 | @uppy/robodog | 3.0.0-beta.4 | | @uppy/remote-sources | 1.0.0-beta.3 | uppy | 3.0.0-beta.4 | - @uppy/companion,@uppy/tus: Upgrade tus-js-client to 3.0.0 (Merlijn Vos / transloadit#3942) - meta: fix release script (Antoine du Hamel) - @uppy/aws-s3-multipart: Correctly handle errors for `prepareUploadParts` (Merlijn Vos / transloadit#3912) - @uppy/store-default: export the class, don't expose `.callbacks` (Antoine du Hamel / transloadit#3928) - @uppy/remote-sources: do not rely on `.name` property (Antoine du Hamel / transloadit#3941) - @uppy/screen-capture: fix TODOs (Antoine du Hamel / transloadit#3930) - @uppy/status-bar: rename internal modules (Antoine du Hamel / transloadit#3929) - @uppy/transloadit: remove static properties in favor of exports (Antoine du Hamel / transloadit#3927) - @uppy/informer: simplify `render` method (Antoine du Hamel / transloadit#3931) - @uppy/url: remove private methods from public API (Antoine du Hamel / transloadit#3934) - @uppy/dashboard: change `copyToClipboard` signature (Antoine du Hamel / transloadit#3933) - @uppy/drop-target: remove `isFileTransfer` from the public API (Antoine du Hamel / transloadit#3932) - meta: improve beta release script (Antoine du Hamel) | Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/transloadit | 2.3.6 | @uppy/robodog | 2.9.2 | | @uppy/tus | 2.4.2 | uppy | 2.13.2 | - @uppy/transloadit: send `assembly-cancelled` only once (Antoine du Hamel / transloadit#3937) - meta: `keepNames` in bundle (Antoine du Hamel / transloadit#3926) - meta: e2e: fix Transloadit test suite with Cypress 10 (Antoine du Hamel / transloadit#3936) - meta: Bump guzzlehttp/guzzle from 7.4.1 to 7.4.5 in /examples/aws-presigned-url (dependabot[bot] / transloadit#3842) - @uppy/tus: fix dependencies (Antoine du Hamel / transloadit#3923) - meta: doc: fix linter failure in `image-editor.md` (Antoine du Hamel / transloadit#3924) - meta: doc: Fix typo in image-editor.md (Ikko Ashimine / transloadit#3921) - website: Docs and header fix (Artur Paikin / transloadit#3920)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.