@uppy/robodog: remove package #3946

aduh95 · 2022-08-03T16:08:23Z

Removal of Robodog is an outcome of the discussion carried out in #3321.

This removes examples/transloadit and examples/transloadit-textarea because that's relying on Robodog. It'd be nice to have the "Remote Sources" examples landed first.

I haven't tested the website changes, but I have a bad feeling about this.

I'm keeping all the robodog-*.md files so the direct links still work.

arturi · 2022-08-03T16:46:20Z

Could we keep the transloadit and textarea examples, but hide them? Easier to put them back asap then.

aduh95 · 2022-08-03T16:56:40Z

Could we keep the transloadit and textarea examples, but hide them? Easier to put them back asap then.

Not really, what do you mean? They have a dependency on Robodog, Yarn won't be able to resolve it. They're still on the 2.x branch if we need them.

Murderlon

Looks good but probably best to checkout the website locally to be sure

arturi · 2022-08-04T13:07:50Z

Using this PR to rewrite the examples now.

arturi · 2022-08-05T16:08:58Z

Updated, needs a local test of all of the examples, please @aduh95, this is an easy one to screw up.

aduh95 · 2022-08-05T22:20:18Z

Could we keep the transloadit and textarea examples

We could (should?) try to re-write those examples instead of deleting them, since we're holding the 3.0.0 release for a few more days.

arturi · 2022-08-05T23:10:57Z

But that’s what I did? https://github.com/transloadit/uppy/pull/3946/files#diff-b9a6c3b2d50c22e037af96fcb0f6dadf88dfeed09b3b4b88d71ad2ed83e8c924

Ah, you mean the /examples, non-website.

aduh95 · 2022-08-15T11:44:50Z

examples/transloadit/main.js

+import robodog from 'uppy'
+import 'uppy/dist/uppy.min.css'


@Murderlon for the migration guide, we could link to the commit where we migrate this example out of Robodog, wdyt?

which commit would that be specifically? Current diff is huge, if that one is bite sized it may make sense.

aduh95

Can we make the diff from main instead of remove-robodog and have it in its own branch/PR?

aduh95 · 2022-08-20T10:12:52Z

examples/transloadit/index.html

          <span class="error"></span>
      </form>

      <hr>
-      <h2>robodog.form() with dashboard</h2>
+      <h2>Form with inline Dashboard</h2>


I think I would keep referencing robodog.form, as this is meant to be a migration example. Same below.

aduh95 · 2022-08-20T10:13:48Z

examples/transloadit/index.html

    </main>

-    <script src="./main.js" type="module"></script>
+    <script type="module" src="main.js"></script>


Hum why this change?

* example: showcase migration out of Robodog Co-authored-by: Artur Paikin <artur@arturpaikin.com> * Fix server, apply what was done in #3946 * Do weird things with input[type=file] * fix last example * Improve completion logging * Fix lint Co-authored-by: Artur Paikin <artur@arturpaikin.com>

Co-authored-by: Artur Paikin <artur@arturpaikin.com>

**Migration guides:** https://uppy.io/docs/migration-guides.html | Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.0 | @uppy/progress-bar | 3.0.0 | | @uppy/audio | 1.0.0 | @uppy/provider-views | 3.0.0 | | @uppy/aws-s3 | 3.0.0 | @uppy/react | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.0 | @uppy/react-native | 0.4.0 | | @uppy/box | 2.0.0 | @uppy/redux-dev-tools | 3.0.0 | | @uppy/companion | 4.0.0 | @uppy/remote-sources | 1.0.0 | | @uppy/companion-client | 3.0.0 | @uppy/screen-capture | 3.0.0 | | @uppy/compressor | 1.0.0 | @uppy/status-bar | 3.0.0 | | @uppy/core | 3.0.0 | @uppy/store-default | 3.0.0 | | @uppy/dashboard | 3.0.0 | @uppy/store-redux | 3.0.0 | | @uppy/drag-drop | 3.0.0 | @uppy/svelte | 2.0.0 | | @uppy/drop-target | 2.0.0 | @uppy/thumbnail-generator | 3.0.0 | | @uppy/dropbox | 3.0.0 | @uppy/transloadit | 3.0.0 | | @uppy/facebook | 3.0.0 | @uppy/tus | 3.0.0 | | @uppy/file-input | 3.0.0 | @uppy/unsplash | 3.0.0 | | @uppy/form | 3.0.0 | @uppy/url | 3.0.0 | | @uppy/golden-retriever | 3.0.0 | @uppy/utils | 5.0.0 | | @uppy/google-drive | 3.0.0 | @uppy/vue | 1.0.0 | | @uppy/image-editor | 2.0.0 | @uppy/webcam | 3.0.0 | | @uppy/informer | 3.0.0 | @uppy/xhr-upload | 3.0.0 | | @uppy/instagram | 3.0.0 | @uppy/zoom | 2.0.0 | | @uppy/locales | 3.0.0 | uppy | 3.0.0 | | @uppy/onedrive | 3.0.0 | | | - docs: Use RemoteSources in readme example (Artur Paikin / #4030) - docs: Add migration guide for Uppy 3.x, Companion 4.x, and Robodog (Merlijn Vos / #3913) - example: upgrade React example to use React 18 (Antoine du Hamel / #4002) - meta: fix linter failures (Antoine du Hamel / #4029) - @uppy/vue: move `@uppy/` packages to peer dependencies (Antoine du Hamel / #4024) - @uppy/robodog: remove package (Antoine du Hamel / #3946) - example: migrate `digitalocean-spaces` to ESM (Antoine du Hamel / #4015) - example: replace Robodog example with Transloadit + RemoteSources + Form (Antoine du Hamel / #4027) - website: replace Robodog example with Uppy plugins (Artur Paikin / #4026) - @uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: @uppy/tus, @uppy/xhr-upload, @uppy/aws-s3: `metaFields` -> `allowedMetaFields` (Merlijn Vos / #4023) - example: showcase migration out of Robodog (Antoine du Hamel / #4021) - example: fix Svelte dev mode (Antoine du Hamel / #4025) - example: fix docs and env for Vite examples (Antoine du Hamel / #4018) - @uppy/tus: avoid crashing when Tus client reports an error (Antoine du Hamel / #4019) - @uppy/react: move `@uppy/` packages to peer dependencies (Antoine du Hamel / #4004) - @uppy/core: core: uppy.addFile should accept browser File objects (Artur Paikin / #4020) - example: fix svelte example (Antoine du Hamel / #4017) - example: migrate `python-xhr` to ESM (Antoine du Hamel / #4010) - example: migrate `php-xhr` to ESM (Antoine du Hamel / #4009) - example: migrate `node-xhr` to ESM (Antoine du Hamel / #4008) - example: migrate `xhr-bundle` to ESM (Antoine du Hamel / #4012) - example: migrate `multiple-instances` to ESM (Antoine du Hamel / #4007) - example: replace `transloadit-textarea` with `transloadit-markdown-bin` (Antoine du Hamel / #4013) - example: add README to Svelte example (Antoine du Hamel / #4011) - build: Remove size-limit for now (Artur Paikin / #4003) - @uppy/core,@uppy/dashboard,@uppy/status-bar: Style tweaks: use all: initial + other resets (Artur Paikin / #3983) - @uppy/aws-s3: aws-s3: fix incorrect comparison for `file-removed` (Merlijn Vos / #3962) - example: update to new CDN export names (Antoine du Hamel / #4006) - example: fix dependencies of `bundled` example (Antoine du Hamel / #4005) - @uppy/tus: fix dependencies (Antoine du Hamel / #3923) - @uppy/tus: add file argument to `onBeforeRequest` (Merlijn Vos / #3984) - @uppy/utils: fix drop of multiple files on Chromium browsers (Antoine du Hamel / #3998) - @uppy/angular: upgrade to Angular 14 (Antoine du Hamel / #3997) - example: update Angular example to v14 (Antoine du Hamel / #3996) - @uppy/utils: Fix @uppy/utils microtip.scss export (Merlijn Vos / #3995) - docs: Companion: make streaming upload recommended & other docs tweaks (Mikael Finstad / #3994) ### 3.0.0-beta.5 ### 3.0.0-beta.4 ### 3.0.0-beta.3 ### 3.0.0-beta.2 ### 3.0.0-beta.1 ### 3.0.0-beta

* main: (63 commits) @uppy/angular: fix peer dependencies (#4035) uppy.io homepage: Add Tus Fix uppy.io homepage example Release: uppy@3.0.0 (#4031) Update README.md Update README.md meta: Use RemoteSources in readme example (#4030) Add migration guide for Uppy 3.x, Companion 4.x, and Robodog (#3913) example: upgrade React example to use React 18 (#4002) readme: Use new ESM syntax (#4028) fixup! meta: fix linter failures (#4029) @uppy/vue: move `@uppy/` packages to peer dependencies (#4024) meta: fix linter failures (#4029) @uppy/robodog: remove package (#3946) example: migrate `digitalocean-spaces` to ESM (#4015) example: replace Robodog example with Transloadit + RemoteSources + Form (#4027) website: replace Robodog example with Uppy plugins (#4026) @uppy/tus, @uppy/xhr-upload, @uppy/aws-s3: `metaFields` -> `allowedMetaFields` (#4023) example: showcase migration out of Robodog (#4021) example: fix Svelte dev mode (#4025) ...

**Migration guides:** https://uppy.io/docs/migration-guides.html | Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.0 | @uppy/progress-bar | 3.0.0 | | @uppy/audio | 1.0.0 | @uppy/provider-views | 3.0.0 | | @uppy/aws-s3 | 3.0.0 | @uppy/react | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.0 | @uppy/react-native | 0.4.0 | | @uppy/box | 2.0.0 | @uppy/redux-dev-tools | 3.0.0 | | @uppy/companion | 4.0.0 | @uppy/remote-sources | 1.0.0 | | @uppy/companion-client | 3.0.0 | @uppy/screen-capture | 3.0.0 | | @uppy/compressor | 1.0.0 | @uppy/status-bar | 3.0.0 | | @uppy/core | 3.0.0 | @uppy/store-default | 3.0.0 | | @uppy/dashboard | 3.0.0 | @uppy/store-redux | 3.0.0 | | @uppy/drag-drop | 3.0.0 | @uppy/svelte | 2.0.0 | | @uppy/drop-target | 2.0.0 | @uppy/thumbnail-generator | 3.0.0 | | @uppy/dropbox | 3.0.0 | @uppy/transloadit | 3.0.0 | | @uppy/facebook | 3.0.0 | @uppy/tus | 3.0.0 | | @uppy/file-input | 3.0.0 | @uppy/unsplash | 3.0.0 | | @uppy/form | 3.0.0 | @uppy/url | 3.0.0 | | @uppy/golden-retriever | 3.0.0 | @uppy/utils | 5.0.0 | | @uppy/google-drive | 3.0.0 | @uppy/vue | 1.0.0 | | @uppy/image-editor | 2.0.0 | @uppy/webcam | 3.0.0 | | @uppy/informer | 3.0.0 | @uppy/xhr-upload | 3.0.0 | | @uppy/instagram | 3.0.0 | @uppy/zoom | 2.0.0 | | @uppy/locales | 3.0.0 | uppy | 3.0.0 | | @uppy/onedrive | 3.0.0 | | | - docs: Use RemoteSources in readme example (Artur Paikin / transloadit#4030) - docs: Add migration guide for Uppy 3.x, Companion 4.x, and Robodog (Merlijn Vos / transloadit#3913) - example: upgrade React example to use React 18 (Antoine du Hamel / transloadit#4002) - meta: fix linter failures (Antoine du Hamel / transloadit#4029) - @uppy/vue: move `@uppy/` packages to peer dependencies (Antoine du Hamel / transloadit#4024) - @uppy/robodog: remove package (Antoine du Hamel / transloadit#3946) - example: migrate `digitalocean-spaces` to ESM (Antoine du Hamel / transloadit#4015) - example: replace Robodog example with Transloadit + RemoteSources + Form (Antoine du Hamel / transloadit#4027) - website: replace Robodog example with Uppy plugins (Artur Paikin / transloadit#4026) - @uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: @uppy/tus, @uppy/xhr-upload, @uppy/aws-s3: `metaFields` -> `allowedMetaFields` (Merlijn Vos / transloadit#4023) - example: showcase migration out of Robodog (Antoine du Hamel / transloadit#4021) - example: fix Svelte dev mode (Antoine du Hamel / transloadit#4025) - example: fix docs and env for Vite examples (Antoine du Hamel / transloadit#4018) - @uppy/tus: avoid crashing when Tus client reports an error (Antoine du Hamel / transloadit#4019) - @uppy/react: move `@uppy/` packages to peer dependencies (Antoine du Hamel / transloadit#4004) - @uppy/core: core: uppy.addFile should accept browser File objects (Artur Paikin / transloadit#4020) - example: fix svelte example (Antoine du Hamel / transloadit#4017) - example: migrate `python-xhr` to ESM (Antoine du Hamel / transloadit#4010) - example: migrate `php-xhr` to ESM (Antoine du Hamel / transloadit#4009) - example: migrate `node-xhr` to ESM (Antoine du Hamel / transloadit#4008) - example: migrate `xhr-bundle` to ESM (Antoine du Hamel / transloadit#4012) - example: migrate `multiple-instances` to ESM (Antoine du Hamel / transloadit#4007) - example: replace `transloadit-textarea` with `transloadit-markdown-bin` (Antoine du Hamel / transloadit#4013) - example: add README to Svelte example (Antoine du Hamel / transloadit#4011) - build: Remove size-limit for now (Artur Paikin / transloadit#4003) - @uppy/core,@uppy/dashboard,@uppy/status-bar: Style tweaks: use all: initial + other resets (Artur Paikin / transloadit#3983) - @uppy/aws-s3: aws-s3: fix incorrect comparison for `file-removed` (Merlijn Vos / transloadit#3962) - example: update to new CDN export names (Antoine du Hamel / transloadit#4006) - example: fix dependencies of `bundled` example (Antoine du Hamel / transloadit#4005) - @uppy/tus: fix dependencies (Antoine du Hamel / transloadit#3923) - @uppy/tus: add file argument to `onBeforeRequest` (Merlijn Vos / transloadit#3984) - @uppy/utils: fix drop of multiple files on Chromium browsers (Antoine du Hamel / transloadit#3998) - @uppy/angular: upgrade to Angular 14 (Antoine du Hamel / transloadit#3997) - example: update Angular example to v14 (Antoine du Hamel / transloadit#3996) - @uppy/utils: Fix @uppy/utils microtip.scss export (Merlijn Vos / transloadit#3995) - docs: Companion: make streaming upload recommended & other docs tweaks (Mikael Finstad / transloadit#3994) ### 3.0.0-beta.5 ### 3.0.0-beta.4 ### 3.0.0-beta.3 ### 3.0.0-beta.2 ### 3.0.0-beta.1 ### 3.0.0-beta

aduh95 marked this pull request as ready for review August 3, 2022 19:41

Murderlon approved these changes Aug 4, 2022

View reviewed changes

aduh95 changed the base branch from 3.x to main August 4, 2022 16:30

aduh95 force-pushed the remove-robodog branch 2 times, most recently from 5402eac to e77ac0d Compare August 5, 2022 22:08

aduh95 force-pushed the remove-robodog branch from d53b16d to f12e533 Compare August 15, 2022 11:32

aduh95 commented Aug 15, 2022

View reviewed changes

aduh95 force-pushed the main branch from 39f95a0 to 5567be7 Compare August 16, 2022 15:52

aduh95 commented Aug 20, 2022

View reviewed changes

arturi added a commit that referenced this pull request Aug 21, 2022

Fix server, apply what was done in #3946

a1b9641

arturi mentioned this pull request Aug 22, 2022

example: showcase migration out of Robodog #4021

Merged

aduh95 and others added 2 commits August 22, 2022 16:57

@uppy/robodog: remove package

ab53c65

Co-authored-by: Artur Paikin <artur@arturpaikin.com>

clean up

6852ebd

aduh95 force-pushed the remove-robodog branch from 979d59e to 6852ebd Compare August 22, 2022 14:58

aduh95 merged commit 4bb9988 into main Aug 22, 2022

aduh95 deleted the remove-robodog branch August 22, 2022 15:19

github-actions bot mentioned this pull request Aug 22, 2022

Release: uppy@3.0.0 #4031

Merged

H4NG-MAN mentioned this pull request Aug 23, 2022

[Snyk] Security upgrade @uppy/companion from 0.17.5 to 4.0.0 H4NG-MAN/uppy#116

Open

snyk-bot mentioned this pull request Sep 26, 2022

[Snyk] Security upgrade @uppy/companion from 0.17.5 to 4.0.0 H4NG-MAN/uppy#123

Open

H4NG-MAN mentioned this pull request Dec 4, 2022

[Snyk] Security upgrade @uppy/companion from 0.17.5 to 4.0.0 H4NG-MAN/uppy#159

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@uppy/robodog: remove package #3946

@uppy/robodog: remove package #3946

aduh95 commented Aug 3, 2022 •

edited by arturi

arturi commented Aug 3, 2022

aduh95 commented Aug 3, 2022

Murderlon left a comment

arturi commented Aug 4, 2022

arturi commented Aug 5, 2022

aduh95 commented Aug 5, 2022 •

edited

arturi commented Aug 5, 2022 •

edited

aduh95 Aug 15, 2022

Murderlon Aug 16, 2022

arturi Aug 19, 2022

aduh95 left a comment

aduh95 Aug 20, 2022

aduh95 Aug 20, 2022

@uppy/robodog: remove package #3946

@uppy/robodog: remove package #3946

Conversation

aduh95 commented Aug 3, 2022 • edited by arturi

arturi commented Aug 3, 2022

aduh95 commented Aug 3, 2022

Murderlon left a comment

Choose a reason for hiding this comment

arturi commented Aug 4, 2022

arturi commented Aug 5, 2022

aduh95 commented Aug 5, 2022 • edited

arturi commented Aug 5, 2022 • edited

aduh95 Aug 15, 2022

Choose a reason for hiding this comment

Murderlon Aug 16, 2022

Choose a reason for hiding this comment

arturi Aug 19, 2022

Choose a reason for hiding this comment

aduh95 left a comment

Choose a reason for hiding this comment

aduh95 Aug 20, 2022

Choose a reason for hiding this comment

aduh95 Aug 20, 2022

Choose a reason for hiding this comment

aduh95 commented Aug 3, 2022 •

edited by arturi

aduh95 commented Aug 5, 2022 •

edited

arturi commented Aug 5, 2022 •

edited