@uppy/angular: upgrade to Angular 14 #3997

aduh95 · 2022-08-17T10:37:47Z

Notable changes:

@uppy/angular build chain has been upgraded.
BREAKING: Peer dependencies have been updated to match the latest @uppy/core and @uppy/utils.
Resolved the compile warning 'tslib' is no longer recommended to be used as a 'peerDependencies'.

Murderlon

We should also update the migration guide with this if it's breaking

aduh95 · 2022-08-17T13:20:37Z

We should also update the migration guide with this if it's breaking

It's not really breaking, except that now it expects to find Uppy 3.x as peer dependency (because of ESM).

**Migration guides:** https://uppy.io/docs/migration-guides.html | Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.0 | @uppy/progress-bar | 3.0.0 | | @uppy/audio | 1.0.0 | @uppy/provider-views | 3.0.0 | | @uppy/aws-s3 | 3.0.0 | @uppy/react | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.0 | @uppy/react-native | 0.4.0 | | @uppy/box | 2.0.0 | @uppy/redux-dev-tools | 3.0.0 | | @uppy/companion | 4.0.0 | @uppy/remote-sources | 1.0.0 | | @uppy/companion-client | 3.0.0 | @uppy/screen-capture | 3.0.0 | | @uppy/compressor | 1.0.0 | @uppy/status-bar | 3.0.0 | | @uppy/core | 3.0.0 | @uppy/store-default | 3.0.0 | | @uppy/dashboard | 3.0.0 | @uppy/store-redux | 3.0.0 | | @uppy/drag-drop | 3.0.0 | @uppy/svelte | 2.0.0 | | @uppy/drop-target | 2.0.0 | @uppy/thumbnail-generator | 3.0.0 | | @uppy/dropbox | 3.0.0 | @uppy/transloadit | 3.0.0 | | @uppy/facebook | 3.0.0 | @uppy/tus | 3.0.0 | | @uppy/file-input | 3.0.0 | @uppy/unsplash | 3.0.0 | | @uppy/form | 3.0.0 | @uppy/url | 3.0.0 | | @uppy/golden-retriever | 3.0.0 | @uppy/utils | 5.0.0 | | @uppy/google-drive | 3.0.0 | @uppy/vue | 1.0.0 | | @uppy/image-editor | 2.0.0 | @uppy/webcam | 3.0.0 | | @uppy/informer | 3.0.0 | @uppy/xhr-upload | 3.0.0 | | @uppy/instagram | 3.0.0 | @uppy/zoom | 2.0.0 | | @uppy/locales | 3.0.0 | uppy | 3.0.0 | | @uppy/onedrive | 3.0.0 | | | - docs: Use RemoteSources in readme example (Artur Paikin / #4030) - docs: Add migration guide for Uppy 3.x, Companion 4.x, and Robodog (Merlijn Vos / #3913) - example: upgrade React example to use React 18 (Antoine du Hamel / #4002) - meta: fix linter failures (Antoine du Hamel / #4029) - @uppy/vue: move `@uppy/` packages to peer dependencies (Antoine du Hamel / #4024) - @uppy/robodog: remove package (Antoine du Hamel / #3946) - example: migrate `digitalocean-spaces` to ESM (Antoine du Hamel / #4015) - example: replace Robodog example with Transloadit + RemoteSources + Form (Antoine du Hamel / #4027) - website: replace Robodog example with Uppy plugins (Artur Paikin / #4026) - @uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: @uppy/tus, @uppy/xhr-upload, @uppy/aws-s3: `metaFields` -> `allowedMetaFields` (Merlijn Vos / #4023) - example: showcase migration out of Robodog (Antoine du Hamel / #4021) - example: fix Svelte dev mode (Antoine du Hamel / #4025) - example: fix docs and env for Vite examples (Antoine du Hamel / #4018) - @uppy/tus: avoid crashing when Tus client reports an error (Antoine du Hamel / #4019) - @uppy/react: move `@uppy/` packages to peer dependencies (Antoine du Hamel / #4004) - @uppy/core: core: uppy.addFile should accept browser File objects (Artur Paikin / #4020) - example: fix svelte example (Antoine du Hamel / #4017) - example: migrate `python-xhr` to ESM (Antoine du Hamel / #4010) - example: migrate `php-xhr` to ESM (Antoine du Hamel / #4009) - example: migrate `node-xhr` to ESM (Antoine du Hamel / #4008) - example: migrate `xhr-bundle` to ESM (Antoine du Hamel / #4012) - example: migrate `multiple-instances` to ESM (Antoine du Hamel / #4007) - example: replace `transloadit-textarea` with `transloadit-markdown-bin` (Antoine du Hamel / #4013) - example: add README to Svelte example (Antoine du Hamel / #4011) - build: Remove size-limit for now (Artur Paikin / #4003) - @uppy/core,@uppy/dashboard,@uppy/status-bar: Style tweaks: use all: initial + other resets (Artur Paikin / #3983) - @uppy/aws-s3: aws-s3: fix incorrect comparison for `file-removed` (Merlijn Vos / #3962) - example: update to new CDN export names (Antoine du Hamel / #4006) - example: fix dependencies of `bundled` example (Antoine du Hamel / #4005) - @uppy/tus: fix dependencies (Antoine du Hamel / #3923) - @uppy/tus: add file argument to `onBeforeRequest` (Merlijn Vos / #3984) - @uppy/utils: fix drop of multiple files on Chromium browsers (Antoine du Hamel / #3998) - @uppy/angular: upgrade to Angular 14 (Antoine du Hamel / #3997) - example: update Angular example to v14 (Antoine du Hamel / #3996) - @uppy/utils: Fix @uppy/utils microtip.scss export (Merlijn Vos / #3995) - docs: Companion: make streaming upload recommended & other docs tweaks (Mikael Finstad / #3994) ### 3.0.0-beta.5 ### 3.0.0-beta.4 ### 3.0.0-beta.3 ### 3.0.0-beta.2 ### 3.0.0-beta.1 ### 3.0.0-beta

jcompagner · 2022-08-23T09:10:22Z

one question do you want to support still older angular versions?
because currently this commit does break that, you need no angular 14

node_modules@uppy\angular\fesm2015\uppy-angular.mjs: This application depends upon a library published using Angular version 14.1.3, which requires Angular version 14.0.0 or newer to work correctly.
Consider upgrading your application to use a more recent version of Angular.

50 | DashboardComponent.Éµfac = i0.ÉµÉµngDeclareFactory({ minVersion: "12.0.0", version: "14.1.3", ngImport: i0, type: DashboardComponent, deps: [{ token: i0.ElementRef }], target: i0.ÉµÉµFactoryTarget.Component });

51 | DashboardComponent.Éµcmp = i0.ÉµÉµngDeclareComponent({ minVersion: "14.0.0", version: "14.1.3", type: DashboardComponent, selector: "uppy-dashboard", inputs: { uppy: "uppy", props: "props" }, usesInheritance: true, usesOnChanges: true, ngImport: i0, template: '', isInline: true, changeDetection: i0.ChangeDetectionStrategy.OnPush });

the weird hin issomewhere there is a minVersion of 12
but then there is also a minVersion of 14

and if you publish (build) really with angular 14 then all components need to be deployed on angular 14..

aduh95 · 2022-08-23T10:01:09Z

@jcompagner yes sorry, the peer dependencies should had been updated to reflect that change and explicitly remove Angular 13 and below from the support list. If you are using a previous version of Angular, you can keep using @uppy/angular v0.3.x which is still in maintenance and critical/security bug fixes will still be backported to it.

Our library is being published using Angular version 14.x, which requires Angular version 14.0.0 or newer to work correctly. Refs: transloadit#3997 (comment)

Our library is being published using Angular version 14.x, which requires Angular version 14.0.0 or newer to work correctly. Refs: #3997 (comment)

**Migration guides:** https://uppy.io/docs/migration-guides.html | Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/angular | 0.4.0 | @uppy/progress-bar | 3.0.0 | | @uppy/audio | 1.0.0 | @uppy/provider-views | 3.0.0 | | @uppy/aws-s3 | 3.0.0 | @uppy/react | 3.0.0 | | @uppy/aws-s3-multipart | 3.0.0 | @uppy/react-native | 0.4.0 | | @uppy/box | 2.0.0 | @uppy/redux-dev-tools | 3.0.0 | | @uppy/companion | 4.0.0 | @uppy/remote-sources | 1.0.0 | | @uppy/companion-client | 3.0.0 | @uppy/screen-capture | 3.0.0 | | @uppy/compressor | 1.0.0 | @uppy/status-bar | 3.0.0 | | @uppy/core | 3.0.0 | @uppy/store-default | 3.0.0 | | @uppy/dashboard | 3.0.0 | @uppy/store-redux | 3.0.0 | | @uppy/drag-drop | 3.0.0 | @uppy/svelte | 2.0.0 | | @uppy/drop-target | 2.0.0 | @uppy/thumbnail-generator | 3.0.0 | | @uppy/dropbox | 3.0.0 | @uppy/transloadit | 3.0.0 | | @uppy/facebook | 3.0.0 | @uppy/tus | 3.0.0 | | @uppy/file-input | 3.0.0 | @uppy/unsplash | 3.0.0 | | @uppy/form | 3.0.0 | @uppy/url | 3.0.0 | | @uppy/golden-retriever | 3.0.0 | @uppy/utils | 5.0.0 | | @uppy/google-drive | 3.0.0 | @uppy/vue | 1.0.0 | | @uppy/image-editor | 2.0.0 | @uppy/webcam | 3.0.0 | | @uppy/informer | 3.0.0 | @uppy/xhr-upload | 3.0.0 | | @uppy/instagram | 3.0.0 | @uppy/zoom | 2.0.0 | | @uppy/locales | 3.0.0 | uppy | 3.0.0 | | @uppy/onedrive | 3.0.0 | | | - docs: Use RemoteSources in readme example (Artur Paikin / transloadit#4030) - docs: Add migration guide for Uppy 3.x, Companion 4.x, and Robodog (Merlijn Vos / transloadit#3913) - example: upgrade React example to use React 18 (Antoine du Hamel / transloadit#4002) - meta: fix linter failures (Antoine du Hamel / transloadit#4029) - @uppy/vue: move `@uppy/` packages to peer dependencies (Antoine du Hamel / transloadit#4024) - @uppy/robodog: remove package (Antoine du Hamel / transloadit#3946) - example: migrate `digitalocean-spaces` to ESM (Antoine du Hamel / transloadit#4015) - example: replace Robodog example with Transloadit + RemoteSources + Form (Antoine du Hamel / transloadit#4027) - website: replace Robodog example with Uppy plugins (Artur Paikin / transloadit#4026) - @uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: @uppy/tus, @uppy/xhr-upload, @uppy/aws-s3: `metaFields` -> `allowedMetaFields` (Merlijn Vos / transloadit#4023) - example: showcase migration out of Robodog (Antoine du Hamel / transloadit#4021) - example: fix Svelte dev mode (Antoine du Hamel / transloadit#4025) - example: fix docs and env for Vite examples (Antoine du Hamel / transloadit#4018) - @uppy/tus: avoid crashing when Tus client reports an error (Antoine du Hamel / transloadit#4019) - @uppy/react: move `@uppy/` packages to peer dependencies (Antoine du Hamel / transloadit#4004) - @uppy/core: core: uppy.addFile should accept browser File objects (Artur Paikin / transloadit#4020) - example: fix svelte example (Antoine du Hamel / transloadit#4017) - example: migrate `python-xhr` to ESM (Antoine du Hamel / transloadit#4010) - example: migrate `php-xhr` to ESM (Antoine du Hamel / transloadit#4009) - example: migrate `node-xhr` to ESM (Antoine du Hamel / transloadit#4008) - example: migrate `xhr-bundle` to ESM (Antoine du Hamel / transloadit#4012) - example: migrate `multiple-instances` to ESM (Antoine du Hamel / transloadit#4007) - example: replace `transloadit-textarea` with `transloadit-markdown-bin` (Antoine du Hamel / transloadit#4013) - example: add README to Svelte example (Antoine du Hamel / transloadit#4011) - build: Remove size-limit for now (Artur Paikin / transloadit#4003) - @uppy/core,@uppy/dashboard,@uppy/status-bar: Style tweaks: use all: initial + other resets (Artur Paikin / transloadit#3983) - @uppy/aws-s3: aws-s3: fix incorrect comparison for `file-removed` (Merlijn Vos / transloadit#3962) - example: update to new CDN export names (Antoine du Hamel / transloadit#4006) - example: fix dependencies of `bundled` example (Antoine du Hamel / transloadit#4005) - @uppy/tus: fix dependencies (Antoine du Hamel / transloadit#3923) - @uppy/tus: add file argument to `onBeforeRequest` (Merlijn Vos / transloadit#3984) - @uppy/utils: fix drop of multiple files on Chromium browsers (Antoine du Hamel / transloadit#3998) - @uppy/angular: upgrade to Angular 14 (Antoine du Hamel / transloadit#3997) - example: update Angular example to v14 (Antoine du Hamel / transloadit#3996) - @uppy/utils: Fix @uppy/utils microtip.scss export (Merlijn Vos / transloadit#3995) - docs: Companion: make streaming upload recommended & other docs tweaks (Mikael Finstad / transloadit#3994) ### 3.0.0-beta.5 ### 3.0.0-beta.4 ### 3.0.0-beta.3 ### 3.0.0-beta.2 ### 3.0.0-beta.1 ### 3.0.0-beta

@uppy/angular: upgrade to Angular 14

59cf6c6

github-actions bot added the pending end-to-end tests label Aug 17, 2022

Murderlon approved these changes Aug 17, 2022

View reviewed changes

fixup! @uppy/angular: upgrade to Angular 14

f39440b

aduh95 merged commit 03d0590 into transloadit:main Aug 17, 2022

github-actions bot mentioned this pull request Aug 22, 2022

Release: uppy@3.0.0 #4031

Merged

aduh95 deleted the angular-upgrade branch August 23, 2022 09:22

aduh95 added a commit to aduh95/uppy that referenced this pull request Aug 23, 2022

@uppy/angular: fix peer dependencies

64e15ac

Our library is being published using Angular version 14.x, which requires Angular version 14.0.0 or newer to work correctly. Refs: transloadit#3997 (comment)

aduh95 mentioned this pull request Aug 23, 2022

@uppy/angular: fix peer dependencies #4035

Merged

aduh95 added a commit that referenced this pull request Aug 23, 2022

@uppy/angular: fix peer dependencies (#4035)

2ce8036

Our library is being published using Angular version 14.x, which requires Angular version 14.0.0 or newer to work correctly. Refs: #3997 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@uppy/angular: upgrade to Angular 14 #3997

@uppy/angular: upgrade to Angular 14 #3997

aduh95 commented Aug 17, 2022

Murderlon left a comment

aduh95 commented Aug 17, 2022

jcompagner commented Aug 23, 2022

aduh95 commented Aug 23, 2022

@uppy/angular: upgrade to Angular 14 #3997

@uppy/angular: upgrade to Angular 14 #3997

Conversation

aduh95 commented Aug 17, 2022

Murderlon left a comment

Choose a reason for hiding this comment

aduh95 commented Aug 17, 2022

jcompagner commented Aug 23, 2022

aduh95 commented Aug 23, 2022