Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: improve CI npm install time #4058

Merged
merged 3 commits into from Aug 30, 2022
Merged

meta: improve CI npm install time #4058

merged 3 commits into from Aug 30, 2022

Conversation

aduh95
Copy link
Member

@aduh95 aduh95 commented Aug 30, 2022

We can skip the install of Cypress in all CI jobs but the e2e (which should improve things) and we can cache Cypress cache which should also improve things.

I'm also using yarn workspaces focus feature to cut down even more on the install time, especially in the Companion CI that don't need any deps expects Companion's.

@arturi arturi requested a review from mifi August 30, 2022 09:47
Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI improvements always very welcome 👍

- name: Install Node.js
uses: actions/setup-node@v3
with:
node-version: lts/*
- name: Install dependencies
run: corepack yarn install --immutable
env:
# https://docs.cypress.io/guides/references/advanced-installation#Binary-cache
CYPRESS_CACHE_FOLDER: ${{ steps.cypress-cache-dir-path.outputs.dir }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this can work without centralized remote caching? We get a random new machine on GitHub Actions every time AFAIK so this would never be present?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 aduh95 merged commit 9c5fc02 into main Aug 30, 2022
@aduh95 aduh95 deleted the cypress-ci-skip-and-cache branch August 30, 2022 12:50
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
github-actions bot added a commit that referenced this pull request Aug 30, 2022
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/angular             |   0.4.1 | @uppy/store-default       |   3.0.1 |
| @uppy/audio               |   1.0.1 | @uppy/store-redux         |   3.0.1 |
| @uppy/aws-s3              |   3.0.1 | @uppy/svelte              |   3.0.0 |
| @uppy/aws-s3-multipart    |   3.0.1 | @uppy/thumbnail-generator |   3.0.1 |
| @uppy/companion           |   4.0.1 | @uppy/transloadit         |   3.0.1 |
| @uppy/companion-client    |   3.0.1 | @uppy/tus                 |   3.0.1 |
| @uppy/core                |   3.0.1 | @uppy/utils               |   5.0.1 |
| @uppy/dashboard           |   3.0.1 | @uppy/webcam              |   3.1.0 |
| @uppy/react               |   3.0.1 | @uppy/xhr-upload          |   3.0.1 |
| @uppy/remote-sources      |   1.0.1 | uppy                      |   3.0.1 |

- @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / #4047)
- meta: upgrade to Jest 29 (Antoine du Hamel / #4049)
- @uppy/svelte: update peer dependencies (Antoine du Hamel / #4065)
- @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / #4062)
- @uppy/vue: fix missing component in docs (Antoine du Hamel / #4063)
- @uppy/angular: fix compiler warning (Antoine du Hamel / #4064)
- meta: improve CI npm install time (Antoine du Hamel / #4058)
- meta: example: fix Angular example package name (Antoine du Hamel / #4060)
- meta: upgrade to TypeScript 4.8 (Antoine du Hamel / #4048)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / #4055)
- @uppy/transloadit: improve deprecation notice (Antoine du Hamel / #4056)
- @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / #4054)
- @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / #4043)
- @uppy/companion: Fix Companion license (Merlijn Vos / #4044)
- e2e: add tests for AWS (Antoine du Hamel / #3665)
- meta: Only publish Companion to Dockerhub on release (Merlijn Vos / #4037)
- meta: fix linter warnings (Antoine du Hamel / #4039)
- @uppy/utils: Post-release website fixes (Merlijn Vos / #4038)
- @uppy/angular: fix peer dependencies (Antoine du Hamel / #4035)
- meta: uppy.io homepage: Add Tus (Artur Paikin)
- meta: Fix uppy.io homepage example (Artur Paikin)
aduh95 added a commit that referenced this pull request Aug 31, 2022
aduh95 added a commit that referenced this pull request Aug 31, 2022
github-actions bot added a commit that referenced this pull request Sep 25, 2022
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/angular             |   0.3.2 | @uppy/thumbnail-generator |   2.2.2 |
| @uppy/core                |   2.3.4 | @uppy/robodog             |   2.9.5 |
| @uppy/dashboard           |   2.4.3 | uppy                      |  2.13.6 |
| @uppy/golden-retriever    |   2.1.2 |                           |         |

- @uppy/golden-retriever: Fix endless webcam re-render with Golden Retriever (Merlijn Vos / #4111)
- meta: run CI when modifying workflow files (Antoine du Hamel / #4091)
- meta: limit the number of unnecessary CI runs (Antoine du Hamel / #4086)
- meta: fix typo in `e2e.yml` (Antoine du Hamel)
- meta: Restrict e2e CI runs (Merlijn Vos / #4075)
- @uppy/core: Fix `Restrictor` counts ghost files against `maxNumberOfFiles` (Andrew McIntee / #4078)
- meta: improve CI npm install time (Antoine du Hamel / #4058)
- meta: fix Node.js 12.x CI (Antoine du Hamel)
- @uppy/core: fix types (Antoine du Hamel / #4072)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / #4055)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/angular             |   0.4.1 | @uppy/store-default       |   3.0.1 |
| @uppy/audio               |   1.0.1 | @uppy/store-redux         |   3.0.1 |
| @uppy/aws-s3              |   3.0.1 | @uppy/svelte              |   3.0.0 |
| @uppy/aws-s3-multipart    |   3.0.1 | @uppy/thumbnail-generator |   3.0.1 |
| @uppy/companion           |   4.0.1 | @uppy/transloadit         |   3.0.1 |
| @uppy/companion-client    |   3.0.1 | @uppy/tus                 |   3.0.1 |
| @uppy/core                |   3.0.1 | @uppy/utils               |   5.0.1 |
| @uppy/dashboard           |   3.0.1 | @uppy/webcam              |   3.1.0 |
| @uppy/react               |   3.0.1 | @uppy/xhr-upload          |   3.0.1 |
| @uppy/remote-sources      |   1.0.1 | uppy                      |   3.0.1 |

- @uppy/dashboard,@uppy/webcam: add nativeCameraFacingMode to Webcam and Dashboard (Artur Paikin / transloadit#4047)
- meta: upgrade to Jest 29 (Antoine du Hamel / transloadit#4049)
- @uppy/svelte: update peer dependencies (Antoine du Hamel / transloadit#4065)
- @uppy/react: useUppy: fix unmount on NextJS dev mode (Matt Jesuele / transloadit#4062)
- @uppy/vue: fix missing component in docs (Antoine du Hamel / transloadit#4063)
- @uppy/angular: fix compiler warning (Antoine du Hamel / transloadit#4064)
- meta: improve CI npm install time (Antoine du Hamel / transloadit#4058)
- meta: example: fix Angular example package name (Antoine du Hamel / transloadit#4060)
- meta: upgrade to TypeScript 4.8 (Antoine du Hamel / transloadit#4048)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: update definition type files for TS 4.8 compatibility (Antoine du Hamel / transloadit#4055)
- @uppy/transloadit: improve deprecation notice (Antoine du Hamel / transloadit#4056)
- @uppy/thumbnail-generator: fix `exifr` import (Antoine du Hamel / transloadit#4054)
- @uppy/utils: fix `relativePath` when drag&dropping a folder (Antoine du Hamel / transloadit#4043)
- @uppy/companion: Fix Companion license (Merlijn Vos / transloadit#4044)
- e2e: add tests for AWS (Antoine du Hamel / transloadit#3665)
- meta: Only publish Companion to Dockerhub on release (Merlijn Vos / transloadit#4037)
- meta: fix linter warnings (Antoine du Hamel / transloadit#4039)
- @uppy/utils: Post-release website fixes (Merlijn Vos / transloadit#4038)
- @uppy/angular: fix peer dependencies (Antoine du Hamel / transloadit#4035)
- meta: uppy.io homepage: Add Tus (Artur Paikin)
- meta: Fix uppy.io homepage example (Artur Paikin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants