@uppy/aws-s3-multipart: Fix typo in url check #4211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
changed the title
aduh95
approved these changes
Nov 13, 2022
aduh95
added
the
safe to test
github-actions
bot
removed
pending end-to-end tests
safe to test
|
Thank you! |
Merged
github-actions bot
added a commit
that referenced
this pull request
Nov 16, 2022
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.5.1 | @uppy/companion-client | 3.1.1 | | @uppy/aws-s3-multipart | 3.1.1 | @uppy/utils | 5.1.1 | | @uppy/companion | 4.1.1 | uppy | 3.3.1 | - @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / #4213) - @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / #4221) - @uppy/utils: fix types (Antoine du Hamel / #4212) - @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / #4214) - docs: fix `allowedMetaFields` documentation (Antoine du Hamel / #4216) - meta: add more bundlers for automated testing (Antoine du Hamel / #4100) - @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / #4211) - meta: use current version of packages when testing bundlers (Antoine du Hamel / #4208) - meta: do not use the set-output command in workflows (Antoine du Hamel / #4175)
Murderlon
added a commit
that referenced
this pull request
Dec 1, 2022
* main: (110 commits) @uppy/aws-s3-multipart: handle slow connections better (#4213) @uppy/companion-client: treat `*` the same as missing header (#4221) @uppy/utils: fix types (#4212) @uppy/companion: send expire info for non-multipart uploads (#4214) docs: fix `allowedMetaFields` documentation (#4216) meta: add more bundlers for automated testing (#4100) @uppy/aws-s3-multipart: Fix typo in url check (#4211) meta: use current version of packages when testing bundlers (#4208) meta: do not use the set-output command in workflows (#4175) Release: uppy@3.3.0 (#4207) Companion: change default S3 expiry from 300 to 800 seconds (#4206) Dashboard: Single file mode (#4188) Fix UZ locale (#4178) @uppy/utils: update typings for `RateLimitedQueue` (#4204) @uppy/aws-s3-multipart: empty the queue when pausing (#4203) image-editor: add checkered background (#4194) @uppy/aws-s3-multipart: refactor rate limiting approach (#4187) @uppy/companion: send expiry time along side S3 signed requests (#4202) @uppy/companion-client: add support for `AbortSignal` (#4201) @uppy/companion-client: prevent preflight race condition (#4182) ...
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.5.1 | @uppy/companion-client | 3.1.1 | | @uppy/aws-s3-multipart | 3.1.1 | @uppy/utils | 5.1.1 | | @uppy/companion | 4.1.1 | uppy | 3.3.1 | - @uppy/aws-s3-multipart: handle slow connections better (Antoine du Hamel / transloadit#4213) - @uppy/companion-client: treat `*` the same as missing header (Antoine du Hamel / transloadit#4221) - @uppy/utils: fix types (Antoine du Hamel / transloadit#4212) - @uppy/companion: send expire info for non-multipart uploads (Antoine du Hamel / transloadit#4214) - docs: fix `allowedMetaFields` documentation (Antoine du Hamel / transloadit#4216) - meta: add more bundlers for automated testing (Antoine du Hamel / transloadit#4100) - @uppy/aws-s3-multipart: Fix typo in url check (Christian Franke / transloadit#4211) - meta: use current version of packages when testing bundlers (Antoine du Hamel / transloadit#4208) - meta: do not use the set-output command in workflows (Antoine du Hamel / transloadit#4175)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newly introduced check contains a typo. It should check
file.remote.urlnotfile.remove.url.