Use load balancer for companion in e2e tests #4228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by reordering code
also reorder/group vars
|
not sure what's the purpose of |
aduh95
reviewed
Nov 28, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
doesn't seem to work on node 14
|
Ideally, we make changes to |
That's not necessary, we just need to check the result of
It's to allow us to test PRs from forks without exposing the repo secrets – it has to run on the old code to avoid a malicious actor leaking those secrets by opening a PR. |
|
Good point, the other one is indeed successful |
|
Is this ready to merge? |
|
No objections to merging |
Murderlon
approved these changes
Jan 5, 2023
aduh95
reviewed
Jan 5, 2023
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
Feb 2, 2023
Merged
github-actions bot
added a commit
that referenced
this pull request
Feb 13, 2023
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.0.4 | @uppy/screen-capture | 3.0.2 | | @uppy/companion | 4.3.0 | @uppy/transloadit | 3.1.1 | | @uppy/core | 3.0.6 | @uppy/xhr-upload | 3.1.0 | | @uppy/dashboard | 3.2.2 | uppy | 3.5.0 | | @uppy/locales | 3.0.6 | | | - @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / #4316) - meta: Remove Robodog advice, since it is deprecated (Artur Paikin) - @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / #4306) - @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / #4292) - @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / #4302) - @uppy/locales: Update de_DE.js (Jörn Velten / #4297) - meta: use load balancer for companion in e2e tests (Mikael Finstad / #4228) - @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / #4286) - @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / #4247) - @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / #4282)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.0.4 | @uppy/screen-capture | 3.0.2 | | @uppy/companion | 4.3.0 | @uppy/transloadit | 3.1.1 | | @uppy/core | 3.0.6 | @uppy/xhr-upload | 3.1.0 | | @uppy/dashboard | 3.2.2 | uppy | 3.5.0 | | @uppy/locales | 3.0.6 | | | - @uppy/transloadit: fix `assemblyOptions` option (Antoine du Hamel / transloadit#4316) - meta: Remove Robodog advice, since it is deprecated (Artur Paikin) - @uppy/dashboard: fix dashboard acquirers list (Mikael Finstad / transloadit#4306) - @uppy/dashboard: Dashboard: disallow clicking on buttons and links in Dashboard disabled mode (Artur Paikin / transloadit#4292) - @uppy/audio,@uppy/core,@uppy/dashboard,@uppy/screen-capture: Warn more instead of erroring (Artur Paikin / transloadit#4302) - @uppy/locales: Update de_DE.js (Jörn Velten / transloadit#4297) - meta: use load balancer for companion in e2e tests (Mikael Finstad / transloadit#4228) - @uppy/companion: @uppy/companion upgrade grant dependency (Scott Bessler / transloadit#4286) - @uppy/xhr-upload: add `'upload-stalled'` event (Antoine du Hamel / transloadit#4247) - @uppy/locales: minor enhancements and typo fixes for the hungarian translation (KergeKacsa / transloadit#4282)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also
Review tip: check individual commits