Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the website #4369

Merged
merged 11 commits into from
Mar 23, 2023
Merged

Remove the website #4369

merged 11 commits into from
Mar 23, 2023

Conversation

Murderlon
Copy link
Member

@Murderlon Murderlon commented Mar 22, 2023

  • Remove website/
  • Remove GitHub Action for website deploy
  • Remove browser sync config
  • Remove script to update locales in docs files

@aduh95
Copy link
Member

aduh95 commented Mar 22, 2023

I think before we land this, we want:

  • The new website to be live at uppy.io
  • Have a banner here saying this is an old version of the website

That way, we can still redirect folks to https://transloadit.github.io/uppy/ if they miss something from the old website for some reason, but it's clear that it is not up-to-date.

@Murderlon
Copy link
Member Author

I was definitely not planning to merge this before the new website is live. However, I don't think we should keep both up. We should make sure all docs are there and if something is missing we can add it fast or people look in git if they must.

@arturi
Copy link
Contributor

arturi commented Mar 22, 2023

+1 on having the old website around at https://transloadit.github.io/uppy/, doesn't cost us anything, and we can reference for what’s missing on the new website easier.

@Murderlon Murderlon added the blocked This is blocked by another issue or PR label Mar 22, 2023
@Murderlon
Copy link
Member Author

We can merge this PR when the new docs have proved themselves.

@mifi
Copy link
Contributor

mifi commented Mar 23, 2023

there's nothing like removing a million lines of code 🤩
however now it seems we have a million line merge conflict 😬

* main:
  fixup! website: update links to work under the new URL (#4371)
  fixup! website: update links to work under the new URL
  website: update links to work under the new URL (#4371)
  website: add a deprecation notice and a link to the new website (#4370)
  @uppy/tus: do not auto-open sockets, clean them up on abort
  @uppy/aws-s3-multipart: do not auto-open sockets, clean them up on abort
  @uppy/companion-client: do not open socket more than once
  meta: deploy to Heroku on every companion commit (#4367)
  @uppy/companion: add connection keep-alive to dropbox (#4365)
@Murderlon
Copy link
Member Author

@aduh95 @arturi note that https://transloadit.github.io/uppy just goes to https://uppy.io so we don't have the old website live at the moment.

@mifi
Copy link
Contributor

mifi commented Mar 23, 2023

can we move all the code from this PR into a separate github repo and then publish that repo as an "archive" for the old docs?

@Murderlon
Copy link
Member Author

I still personally don't understand the fear of not having the old website live at any moment. I'm okay with holding off this PR for a while, but putting in time and effort to switch repos to have it live is something I wouldn't recommend for what it's worth.

@aduh95
Copy link
Member

aduh95 commented Mar 23, 2023

Probably a cache issue on your end Merlijn, I see the old site that address (e.g. try with https://transloadit.github.io/uppy/docs/).
I agree that having an archive repo seems not very useful.

@arturi
Copy link
Contributor

arturi commented Mar 23, 2023

Why can't we have http://transloadit.github.io/uppy/ serve gh-pages of the current repo? Should be the case now.

@arturi
Copy link
Contributor

arturi commented Mar 23, 2023

Homepage not loading for me either https://transloadit.github.io/uppy/

@aduh95
Copy link
Member

aduh95 commented Mar 23, 2023

I've fixed the home page (which created conflicts with this PR). The old website is in OK state now (the links on the side menus are broken, other than that AFAICT it's working fine), I suggest we leave it at that, and move forward with this PR. wdyt?

@aduh95
Copy link
Member

aduh95 commented Mar 23, 2023

Specifically, I don't see any scenario where we would want to go back to the old website, I'm not even able to build it locally, even if we realize the new website is missing something critical, it should be faster to implement it on the new website than to make the old website work on our local machine.

@arturi
Copy link
Contributor

arturi commented Mar 23, 2023

Agreed, all I wanted is some sort of accessible archive, and we agreed in the call it will be available by default with no extra effort from us. All good to remove the old one now, I think.

Web Archive also works: https://web.archive.org/web/20230222220437/https://uppy.io/docs/plugins/

* main:
  fixup! website: fix home page
  website: fix home page
@Murderlon Murderlon merged commit 6430a00 into main Mar 23, 2023
@Murderlon Murderlon deleted the remove-website branch March 23, 2023 16:33
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
github-actions bot added a commit that referenced this pull request Apr 4, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/aws-s3           |   3.0.6 | @uppy/status-bar       |   3.1.0 |
| @uppy/aws-s3-multipart |   3.1.3 | @uppy/transloadit      |   3.1.2 |
| @uppy/companion        |   4.4.0 | @uppy/tus              |   3.0.6 |
| @uppy/companion-client |   3.1.2 | @uppy/unsplash         |   3.2.0 |
| @uppy/core             |   3.1.2 | @uppy/url              |   3.3.0 |
| @uppy/dashboard        |   3.3.2 | @uppy/utils            |   5.2.0 |
| @uppy/locales          |   3.1.0 | @uppy/xhr-upload       |   3.1.1 |
| @uppy/provider-views   |   3.2.0 | uppy                   |   3.7.0 |
| @uppy/react            |   3.1.1 |                        |         |

- @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: make sure that we reset serverToken when an upload fails (Mikael Finstad / #4376)
- @uppy/aws-s3-multipart: do not auto-open sockets, clean them up on abort (Antoine du Hamel)
- @uppy/aws-s3: Update types (Minh Hieu / #4294)
- @uppy/companion-client: do not open socket more than once (Artur Paikin)
- @uppy/companion: add `service: 'companion'` to periodic ping (Mikael Finstad / #4383)
- @uppy/companion: add connection keep-alive to dropbox (Mikael Finstad / #4365)
- @uppy/companion: add missing env variable for standalone option (Mikael Finstad / #4382)
- @uppy/companion: add S3 prefix env variable (Mikael Finstad / #4320)
- @uppy/companion: allow local ips when testing (Mikael Finstad / #4328)
- @uppy/companion: fix typo in redis-emitter.js (Ikko Eltociear Ashimine / #4362)
- @uppy/companion: merge Provider/SearchProvider (Mikael Finstad / #4330)
- @uppy/companion: only body parse when needed & increased body size for s3 (Mikael Finstad / #4372)
- @uppy/core: fix bug with `setOptions` (Nguyễn bảo Trung / #4350)
- @uppy/locales: locales: add es_MX (Kevin van Zonneveld / #4393)
- @uppy/locales: locales: add hi_IN (Kevin van Zonneveld / #4391)
- @uppy/provider-views: fix race condition when adding folders (Mikael Finstad / #4384)
- @uppy/provider-views: UI: Use form attribite with a form in doc root to prevent outer form submit (Artur Paikin / #4283)
- @uppy/transloadit: fix socket error message (Artur Paikin / #4352)
- @uppy/tus: do not auto-open sockets, clean them up on abort (Antoine du Hamel)
- meta: add version info in the bundlers CI (Antoine du Hamel / #4386)
- meta: deploy to Heroku on every companion commit (Mikael Finstad / #4367)
- meta: example: migrate `redux` to ESM (Antoine du Hamel / #4158)
- meta: fix all ESLint warnings and turn them into errors (Antoine du Hamel / #4398)
- meta: fixup! website: update links to work under the new URL (Antoine du Hamel / #4371)
- meta: remove duplicate outdated OSS support docs (Mikael Finstad, Artur Paikin / #4364)
- meta: use overrides to make sure no uppy package is fetch from npm (Antoine du Hamel / #4395)
- website: add a deprecation notice and a link to the new website (Antoine du Hamel / #4370)
- website: fix home page (Antoine du Hamel)
- website: Remove the website (Merlijn Vos / #4369)
- website: update links to work under the new URL (Antoine du Hamel / #4371)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/aws-s3           |   3.0.6 | @uppy/status-bar       |   3.1.0 |
| @uppy/aws-s3-multipart |   3.1.3 | @uppy/transloadit      |   3.1.2 |
| @uppy/companion        |   4.4.0 | @uppy/tus              |   3.0.6 |
| @uppy/companion-client |   3.1.2 | @uppy/unsplash         |   3.2.0 |
| @uppy/core             |   3.1.2 | @uppy/url              |   3.3.0 |
| @uppy/dashboard        |   3.3.2 | @uppy/utils            |   5.2.0 |
| @uppy/locales          |   3.1.0 | @uppy/xhr-upload       |   3.1.1 |
| @uppy/provider-views   |   3.2.0 | uppy                   |   3.7.0 |
| @uppy/react            |   3.1.1 |                        |         |

- @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: make sure that we reset serverToken when an upload fails (Mikael Finstad / transloadit#4376)
- @uppy/aws-s3-multipart: do not auto-open sockets, clean them up on abort (Antoine du Hamel)
- @uppy/aws-s3: Update types (Minh Hieu / transloadit#4294)
- @uppy/companion-client: do not open socket more than once (Artur Paikin)
- @uppy/companion: add `service: 'companion'` to periodic ping (Mikael Finstad / transloadit#4383)
- @uppy/companion: add connection keep-alive to dropbox (Mikael Finstad / transloadit#4365)
- @uppy/companion: add missing env variable for standalone option (Mikael Finstad / transloadit#4382)
- @uppy/companion: add S3 prefix env variable (Mikael Finstad / transloadit#4320)
- @uppy/companion: allow local ips when testing (Mikael Finstad / transloadit#4328)
- @uppy/companion: fix typo in redis-emitter.js (Ikko Eltociear Ashimine / transloadit#4362)
- @uppy/companion: merge Provider/SearchProvider (Mikael Finstad / transloadit#4330)
- @uppy/companion: only body parse when needed & increased body size for s3 (Mikael Finstad / transloadit#4372)
- @uppy/core: fix bug with `setOptions` (Nguyễn bảo Trung / transloadit#4350)
- @uppy/locales: locales: add es_MX (Kevin van Zonneveld / transloadit#4393)
- @uppy/locales: locales: add hi_IN (Kevin van Zonneveld / transloadit#4391)
- @uppy/provider-views: fix race condition when adding folders (Mikael Finstad / transloadit#4384)
- @uppy/provider-views: UI: Use form attribite with a form in doc root to prevent outer form submit (Artur Paikin / transloadit#4283)
- @uppy/transloadit: fix socket error message (Artur Paikin / transloadit#4352)
- @uppy/tus: do not auto-open sockets, clean them up on abort (Antoine du Hamel)
- meta: add version info in the bundlers CI (Antoine du Hamel / transloadit#4386)
- meta: deploy to Heroku on every companion commit (Mikael Finstad / transloadit#4367)
- meta: example: migrate `redux` to ESM (Antoine du Hamel / transloadit#4158)
- meta: fix all ESLint warnings and turn them into errors (Antoine du Hamel / transloadit#4398)
- meta: fixup! website: update links to work under the new URL (Antoine du Hamel / transloadit#4371)
- meta: remove duplicate outdated OSS support docs (Mikael Finstad, Artur Paikin / transloadit#4364)
- meta: use overrides to make sure no uppy package is fetch from npm (Antoine du Hamel / transloadit#4395)
- website: add a deprecation notice and a link to the new website (Antoine du Hamel / transloadit#4370)
- website: fix home page (Antoine du Hamel)
- website: Remove the website (Merlijn Vos / transloadit#4369)
- website: update links to work under the new URL (Antoine du Hamel / transloadit#4371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This is blocked by another issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants