meta: fix all ESLint warnings and turn them into errors #4398

aduh95 · 2023-04-04T12:13:53Z

Now the only warnings left would be prefer-regex-literals and max-length from esliint-config-transloadit, but the codebase has now a total of 0 warnings and 0 errors when running yarn lint. Let's try keep it that way :)

socket-security · 2023-04-04T12:17:59Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package	Version Diff	Capability Access	`+/-` Transitive Count	Publisher
eslint-plugin-unicorn@46.0.0	43.0.2...46.0.0	filesystem	`+4/-0`	sindresorhus
eslint-plugin-jsdoc@40.1.1	39.9.1...40.1.1	filesystem	`+4/-4`	gajus
eslint-plugin-jest@27.2.1	26.9.0...27.2.1	filesystem	`+0/-0`	simenb

Murderlon · 2023-04-04T12:59:04Z

.eslintrc.js

@@ -53,8 +53,15 @@ module.exports = {
      ignore: svgPresentationAttributes,
    }],

+    // Special rules for CI:
+    ...(process.env.CI && {
+      // Some imports are available only after a full build, which we don't do on CI.


raceCondition.mjs

mifi

wow! 🚀

| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3 | 3.0.6 | @uppy/status-bar | 3.1.0 | | @uppy/aws-s3-multipart | 3.1.3 | @uppy/transloadit | 3.1.2 | | @uppy/companion | 4.4.0 | @uppy/tus | 3.0.6 | | @uppy/companion-client | 3.1.2 | @uppy/unsplash | 3.2.0 | | @uppy/core | 3.1.2 | @uppy/url | 3.3.0 | | @uppy/dashboard | 3.3.2 | @uppy/utils | 5.2.0 | | @uppy/locales | 3.1.0 | @uppy/xhr-upload | 3.1.1 | | @uppy/provider-views | 3.2.0 | uppy | 3.7.0 | | @uppy/react | 3.1.1 | | | - @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: make sure that we reset serverToken when an upload fails (Mikael Finstad / #4376) - @uppy/aws-s3-multipart: do not auto-open sockets, clean them up on abort (Antoine du Hamel) - @uppy/aws-s3: Update types (Minh Hieu / #4294) - @uppy/companion-client: do not open socket more than once (Artur Paikin) - @uppy/companion: add `service: 'companion'` to periodic ping (Mikael Finstad / #4383) - @uppy/companion: add connection keep-alive to dropbox (Mikael Finstad / #4365) - @uppy/companion: add missing env variable for standalone option (Mikael Finstad / #4382) - @uppy/companion: add S3 prefix env variable (Mikael Finstad / #4320) - @uppy/companion: allow local ips when testing (Mikael Finstad / #4328) - @uppy/companion: fix typo in redis-emitter.js (Ikko Eltociear Ashimine / #4362) - @uppy/companion: merge Provider/SearchProvider (Mikael Finstad / #4330) - @uppy/companion: only body parse when needed & increased body size for s3 (Mikael Finstad / #4372) - @uppy/core: fix bug with `setOptions` (Nguyễn bảo Trung / #4350) - @uppy/locales: locales: add es_MX (Kevin van Zonneveld / #4393) - @uppy/locales: locales: add hi_IN (Kevin van Zonneveld / #4391) - @uppy/provider-views: fix race condition when adding folders (Mikael Finstad / #4384) - @uppy/provider-views: UI: Use form attribite with a form in doc root to prevent outer form submit (Artur Paikin / #4283) - @uppy/transloadit: fix socket error message (Artur Paikin / #4352) - @uppy/tus: do not auto-open sockets, clean them up on abort (Antoine du Hamel) - meta: add version info in the bundlers CI (Antoine du Hamel / #4386) - meta: deploy to Heroku on every companion commit (Mikael Finstad / #4367) - meta: example: migrate `redux` to ESM (Antoine du Hamel / #4158) - meta: fix all ESLint warnings and turn them into errors (Antoine du Hamel / #4398) - meta: fixup! website: update links to work under the new URL (Antoine du Hamel / #4371) - meta: remove duplicate outdated OSS support docs (Mikael Finstad, Artur Paikin / #4364) - meta: use overrides to make sure no uppy package is fetch from npm (Antoine du Hamel / #4395) - website: add a deprecation notice and a link to the new website (Antoine du Hamel / #4370) - website: fix home page (Antoine du Hamel) - website: Remove the website (Merlijn Vos / #4369) - website: update links to work under the new URL (Antoine du Hamel / #4371)

…4398)

| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/aws-s3 | 3.0.6 | @uppy/status-bar | 3.1.0 | | @uppy/aws-s3-multipart | 3.1.3 | @uppy/transloadit | 3.1.2 | | @uppy/companion | 4.4.0 | @uppy/tus | 3.0.6 | | @uppy/companion-client | 3.1.2 | @uppy/unsplash | 3.2.0 | | @uppy/core | 3.1.2 | @uppy/url | 3.3.0 | | @uppy/dashboard | 3.3.2 | @uppy/utils | 5.2.0 | | @uppy/locales | 3.1.0 | @uppy/xhr-upload | 3.1.1 | | @uppy/provider-views | 3.2.0 | uppy | 3.7.0 | | @uppy/react | 3.1.1 | | | - @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/tus,@uppy/xhr-upload: make sure that we reset serverToken when an upload fails (Mikael Finstad / transloadit#4376) - @uppy/aws-s3-multipart: do not auto-open sockets, clean them up on abort (Antoine du Hamel) - @uppy/aws-s3: Update types (Minh Hieu / transloadit#4294) - @uppy/companion-client: do not open socket more than once (Artur Paikin) - @uppy/companion: add `service: 'companion'` to periodic ping (Mikael Finstad / transloadit#4383) - @uppy/companion: add connection keep-alive to dropbox (Mikael Finstad / transloadit#4365) - @uppy/companion: add missing env variable for standalone option (Mikael Finstad / transloadit#4382) - @uppy/companion: add S3 prefix env variable (Mikael Finstad / transloadit#4320) - @uppy/companion: allow local ips when testing (Mikael Finstad / transloadit#4328) - @uppy/companion: fix typo in redis-emitter.js (Ikko Eltociear Ashimine / transloadit#4362) - @uppy/companion: merge Provider/SearchProvider (Mikael Finstad / transloadit#4330) - @uppy/companion: only body parse when needed & increased body size for s3 (Mikael Finstad / transloadit#4372) - @uppy/core: fix bug with `setOptions` (Nguyễn bảo Trung / transloadit#4350) - @uppy/locales: locales: add es_MX (Kevin van Zonneveld / transloadit#4393) - @uppy/locales: locales: add hi_IN (Kevin van Zonneveld / transloadit#4391) - @uppy/provider-views: fix race condition when adding folders (Mikael Finstad / transloadit#4384) - @uppy/provider-views: UI: Use form attribite with a form in doc root to prevent outer form submit (Artur Paikin / transloadit#4283) - @uppy/transloadit: fix socket error message (Artur Paikin / transloadit#4352) - @uppy/tus: do not auto-open sockets, clean them up on abort (Antoine du Hamel) - meta: add version info in the bundlers CI (Antoine du Hamel / transloadit#4386) - meta: deploy to Heroku on every companion commit (Mikael Finstad / transloadit#4367) - meta: example: migrate `redux` to ESM (Antoine du Hamel / transloadit#4158) - meta: fix all ESLint warnings and turn them into errors (Antoine du Hamel / transloadit#4398) - meta: fixup! website: update links to work under the new URL (Antoine du Hamel / transloadit#4371) - meta: remove duplicate outdated OSS support docs (Mikael Finstad, Artur Paikin / transloadit#4364) - meta: use overrides to make sure no uppy package is fetch from npm (Antoine du Hamel / transloadit#4395) - website: add a deprecation notice and a link to the new website (Antoine du Hamel / transloadit#4370) - website: fix home page (Antoine du Hamel) - website: Remove the website (Merlijn Vos / transloadit#4369) - website: update links to work under the new URL (Antoine du Hamel / transloadit#4371)

aduh95 added 6 commits April 4, 2023 13:59

meta: fix all eslint warnings

6ae87fe

remove references to the website

002b802

Upgrade ESLint packages

6ede0c1

no more warnings

ae71062

remove unrelated files

abce3a7

upgrade caniuse db

52e7108

github-actions bot added the pending end-to-end tests label Apr 4, 2023

aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Apr 4, 2023

github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels Apr 4, 2023

Exclude local packages on CI

524357c

github-actions bot added the pending end-to-end tests label Apr 4, 2023

aduh95 added 6 commits April 4, 2023 14:31

ignore all the non-relative imports on CI

135ed56

Disable import/no-unresolved on CI

167ee60

Merge branch 'main' of https://github.com/transloadit/uppy

bf31795

error on func-names

f44cb21

auto fix on commit

5a61308

turn down for what

22fcd46

aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Apr 4, 2023

github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels Apr 4, 2023

Murderlon reviewed Apr 4, 2023

View reviewed changes

remove unrelated file

3a53683

github-actions bot added the pending end-to-end tests label Apr 4, 2023

aduh95 added the safe to test Add this label on trustworthy PRs to spawn the e2e test suite label Apr 4, 2023

github-actions bot removed pending end-to-end tests safe to test Add this label on trustworthy PRs to spawn the e2e test suite labels Apr 4, 2023

mifi approved these changes Apr 4, 2023

View reviewed changes

aduh95 merged commit 0a7ecea into transloadit:main Apr 4, 2023
22 checks passed

aduh95 deleted the eslint-fixes branch April 4, 2023 13:54

github-actions bot mentioned this pull request Apr 4, 2023

Release: uppy@3.7.0 #4400

Merged

HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023

meta: fix all ESLint warnings and turn them into errors (transloadit#…

a40b21d

…4398)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: fix all ESLint warnings and turn them into errors #4398

meta: fix all ESLint warnings and turn them into errors #4398

aduh95 commented Apr 4, 2023

socket-security bot commented Apr 4, 2023

Murderlon Apr 4, 2023

mifi left a comment

meta: fix all ESLint warnings and turn them into errors #4398

meta: fix all ESLint warnings and turn them into errors #4398

Conversation

aduh95 commented Apr 4, 2023

socket-security bot commented Apr 4, 2023

Murderlon Apr 4, 2023

Choose a reason for hiding this comment

mifi left a comment

Choose a reason for hiding this comment