Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

companion: PostObject incompatibility with S3-compatible solutions #5052

Open
2 tasks done
nerg4l opened this issue Mar 31, 2024 · 2 comments
Open
2 tasks done

companion: PostObject incompatibility with S3-compatible solutions #5052

nerg4l opened this issue Mar 31, 2024 · 2 comments
Labels

Comments

@nerg4l
Copy link

nerg4l commented Mar 31, 2024

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

@uppy/companion supports S3-compatible object storage options like DigitalOcean Spaces. Companion uses createPresignedPost from @aws-sdk/s3-presigned-post which presigns a PostObject operation. One of the S3-compatible options are Cloudflare R2 and Backblaze B2 which doesn't support PostObject operation.

Solution

The same (or at least similar) can be achieved with PutObject which is supported.

Alternatives

A configuration value could be added to fall back to PutObject.

@nerg4l nerg4l added the Feature label Mar 31, 2024
@Murderlon
Copy link
Member

Hi, we wrote this specifically for S3 and only test against that. We implicitly support providers who have a strict compatibility with S3. So I'm not sure if we want to dive into this, as it opens the gate to supporting multiple providers with an almost compatible API.

If you want to increase chances of this being worked on, perhaps include some references or proof that this wouldn't be a big change and that there is no degraded experience for S3.

@Murderlon
Copy link
Member

Related issue: #4505
Another related issue: #4649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants