Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin for Google Photos #2163

Open
fortunto2 opened this issue Mar 30, 2020 · 9 comments · May be fixed by #5061
Open

Plugin for Google Photos #2163

fortunto2 opened this issue Mar 30, 2020 · 9 comments · May be fixed by #5061
Assignees
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature

Comments

@fortunto2
Copy link
Contributor

fortunto2 commented Mar 30, 2020

I would like to know if there are plans to create a plugin for google photos?
If not, maybe I could start creating it, but I need help. Where to begin...
Maybe someone already did?

https://developers.google.com/photos
front:
https://uppy.io/docs/writing-plugins/
back:
https://github.com/transloadit/uppy/tree/master/packages/@uppy/companion
google drive example:
https://github.com/transloadit/uppy/tree/master/packages/%40uppy/companion/src/server/provider/drive
facebook example:
https://github.com/transloadit/uppy/pull/1794/files

@arturi arturi added Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) and removed Triage labels Apr 1, 2020
@ifedapoolarewaju
Copy link
Contributor

Hi @fortunto2 we didn't make plans for Google Photos yet, so it'dl certainly be great if you found time to work on it.

As mentioned in your list, the facebook PR is a perfect example of what it takes to have it implemented.

You can also have a look at the OneDrive PR

For OAuth, Companion uses grant internally, and that is what this configuration corresponds to. It is basically the configuration that will be passed to grant in order for it to handle the OAuth dance. So in the case of Google Photos, we'll be doing something similar that corresponds to values that Grant expects.

I hope this helps! Please let me know if there's anything else you'd like me to clarify.

@tim-kos
Copy link
Member

tim-kos commented Jan 12, 2021

Hey @fortunto2 ,

Do you still plan to work on this? :)

@fortunto2
Copy link
Contributor Author

@tim-kos I didn’t do it unfortunately. In general, the task is urgent, I would like to return to it later.

@arturi
Copy link
Contributor

arturi commented Jan 12, 2021

Closing this for now to help with the issue count, we’d definitely welcome a PR and will assist you or someone who would like to contribute, please mention us here or open a PR.

@arturi arturi closed this as completed Jan 12, 2021
@tomdav999
Copy link

tomdav999 commented Feb 20, 2021

I realize this is closed but the lack of google photos is a glaring omission. Almost every android user has google photos on their phone and photos are automatically uploaded to the cloud when connected via wifi. If there was a case for transloadit / uppy to minimize bandwidth concerns for mobile users and share images via the cloud, google photos would be it.

@benjaminlotan
Copy link

I know this is closed, and i dont know if this is the place, but lack of google photos integration is the reason our company uses filestack instead of uppy. We're always thinking to make the switch someday. <3 <3

@Bayernatoor
Copy link

Adding a comment to bring some attention back to this issue. Google drive plugin is handy but we often get requests from our users for direct access to Google Photos. Any plans to add this?

@mifi
Copy link
Contributor

mifi commented Feb 2, 2024

Not sure how it would be implemented. I’m not super familiar with google photos but I’d imagine that in order for it to actually be useful, the user would need ways to:

  • list and view their albums
  • Search for photos by name, date, ai features?
  • Fast scrub through photos like on the phone with the year/month in the scrollbar (iphone has this for photos, i dunno about android)

If not, how else are people going to find a needle in a haystack of 100000 pictures

if someone can share how google photos works on android or web that could be used as inspiration.

@mifi
Copy link
Contributor

mifi commented Mar 4, 2024

we are now working on a google photos plugin. pr coming soon.

remaining tasks:

  • allow using the same oauth provider (google) for drive and photos, must handle callback differently than currently
  • should we share auth token between google drive and google photos? store accessToken/refreshToken outside providerUserSession, keyed on authProvider?
    • agreed to not share the auth session for now as the easiest implementation.
  • must dynamically set scope based on user requested provider
  • fix tests
  • improve UI (support tiles/grid a.la instagram for albums)
  • sign up for partner program https://developers.google.com/photos/partner-program/overview
  • get more info about images? (batch) https://developers.google.com/photos/library/guides/access-media-items#get-multiple-media-item
  • test expired access token / refresh as well as other error codes
  • show more metadata about photos in the UI? currently the photo name is the file name (XYZ.JPG) which is not very relevant. avilable info is things like: description, date/time, width/height, camera hardware info

links:

@mifi mifi reopened this Mar 4, 2024
@Murderlon Murderlon assigned mifi and unassigned ifedapoolarewaju Mar 4, 2024
@mifi mifi linked a pull request Apr 8, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants