fix: escape single file torrent name #6846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tearfur
added
scope:core
type:fix
Coeur
approved these changes
May 21, 2024
|
cherry-picked in 4.0.x in 459c8d3 |
|
@ckerr Please revert the Consider a Linux user that has a torrent with a single file named It isn't a problem in main because of #6187. |
|
Can confirm, the latest nightly resolves the issue I was having. |
|
Not too sure what you mean... This PR is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6799.
Regression from #2542.
Since the regression PR, Transmission does not sanitize the filename for single-file torrents.
Notes: Fixed
4.0.0bug where the filename for single-file torrents aren't sanitized.P.S.
tr_torrent_files::makeSubpathPortable()doesn't seem like an appropriate name for what it currently does, so I'll be making another PR for it.