Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for HTTP proxy support #92

Closed
bindul opened this issue Jan 11, 2016 · 3 comments
Closed

Request for HTTP proxy support #92

bindul opened this issue Jan 11, 2016 · 3 comments
Labels
Milestone

Comments

@bindul
Copy link

bindul commented Jan 11, 2016

The plug-in, seems to be using HttpClient without any support for HTTP(s) proxy servers. (see CoverallsClient).

While I completely understand most public CI servers do not need this feature, it is valuable when working behind firewalls and debugging configuration / setup.

Support for proxy settings from maven settings.xml would be extremely useful; if not, at least support for command line (http_proxy=...) or configuration parameters in the plugin (with user overrides) would work.

@trautonen trautonen added this to the v4.2.0 milestone Jan 14, 2016
trautonen added a commit that referenced this issue Feb 23, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@trautonen
Copy link
Owner

@bindul can you test with 4.2.0-SNAPSHOT version from https://oss.sonatype.org/? There is now support for Maven settings.xml based proxy.

@bindul
Copy link
Author

bindul commented Feb 24, 2016

@trautonen Thank you for a quick fix. Verified the fix works; I can upload coverage information from behind a proxy using the 4.2.0-SNAPSHOT version of the plugin.

@trautonen
Copy link
Owner

Ok, great to hear. I will do one small feature before releasing 4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants