/
version_test.go
executable file
·197 lines (167 loc) · 6.61 KB
/
version_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
/*
Copyright 2019 The Rook Authors. All rights reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package cluster to manage Kubernetes storage.
package cluster
import (
"context"
"encoding/json"
"testing"
cephv1 "github.com/rook/rook/pkg/apis/ceph.rook.io/v1"
"github.com/rook/rook/pkg/clusterd"
"github.com/rook/rook/pkg/daemon/ceph/client"
cephver "github.com/rook/rook/pkg/operator/ceph/version"
testop "github.com/rook/rook/pkg/operator/test"
"github.com/stretchr/testify/assert"
)
func TestDiffImageSpecAndClusterRunningVersion(t *testing.T) {
// 1st test
fakeImageVersion := cephver.Octopus
fakeRunningVersions := []byte(`
{
"mon": {
"ceph version 16.2.5 (cbff874f9007f1869bfd3821b7e33b2a6ffd4988) pacific (stable)": 1,
"ceph version 17.2.0 (3a54b2b6d167d4a2a19e003a705696d4fe619afc) quincy (stable)": 2
}
}`)
var dummyRunningVersions cephv1.CephDaemonsVersions
err := json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions)
assert.NoError(t, err)
m, err := diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions)
assert.Error(t, err) // Overall is absent
assert.False(t, m)
// 2nd test - more than 1 version means we should upgrade
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 16.2.5 (cbff874f9007f1869bfd3821b7e33b2a6ffd4988) pacific (stable)": 1,
"ceph version 17.2.0 (3a54b2b6d167d4a2a19e003a705696d4fe619afc) quincy (stable)": 2
}
}`)
var dummyRunningVersions2 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions2)
assert.NoError(t, err)
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions2)
assert.NoError(t, err)
assert.True(t, m)
// 3rd test - spec version is lower than running cluster? what's going on?
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 15.2.0 (3a54b2b6d167d4a2a19e003a705696d4fe619afc) octopus (stable)": 2
}
}`)
var dummyRunningVersions3 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions3)
assert.NoError(t, err)
// Allow the downgrade
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions3)
assert.NoError(t, err)
assert.True(t, m)
// 4 test - spec version is higher than running cluster --> we upgrade
fakeImageVersion = cephver.Pacific
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 15.2.5 (cbff874f9007f1869bfd3821b7e33b2a6ffd4988) octopus (stable)": 2
}
}`)
var dummyRunningVersions4 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions4)
assert.NoError(t, err)
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions4)
assert.NoError(t, err)
assert.True(t, m)
// 5 test - spec version and running cluster versions are identical --> we upgrade
fakeImageVersion = cephver.CephVersion{Major: 16, Minor: 2, Extra: 2,
CommitID: "3a54b2b6d167d4a2a19e003a705696d4fe619afc"}
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 16.2.2 (3a54b2b6d167d4a2a19e003a705696d4fe619afc) pacific (stable)": 2
}
}`)
var dummyRunningVersions5 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions5)
assert.NoError(t, err)
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions5)
assert.NoError(t, err)
assert.False(t, m)
// 6 test - spec version and running cluster have different commit ID
fakeImageVersion = cephver.CephVersion{Major: 16, Minor: 2, Extra: 11, Build: 139,
CommitID: "5c0dc966af809fd1d429ec7bac48962a746af243"}
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 16.2.11-139.el8cp (3a54b2b6d167d4a2a19e003a705696d4fe619afc) pacific (stable)": 2
}
}`)
var dummyRunningVersions6 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions6)
assert.NoError(t, err)
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions6)
assert.NoError(t, err)
assert.True(t, m)
// 7 test - spec version and running cluster have same commit ID
fakeImageVersion = cephver.CephVersion{Major: 16, Minor: 2, Extra: 11, Build: 139,
CommitID: "3a54b2b6d167d4a2a19e003a705696d4fe619afc"}
fakeRunningVersions = []byte(`
{
"overall": {
"ceph version 16.2.11-139.el8cp (3a54b2b6d167d4a2a19e003a705696d4fe619afc) pacific (stable)": 2
}
}`)
var dummyRunningVersions7 cephv1.CephDaemonsVersions
err = json.Unmarshal([]byte(fakeRunningVersions), &dummyRunningVersions7)
assert.NoError(t, err)
m, err = diffImageSpecAndClusterRunningVersion(fakeImageVersion, dummyRunningVersions7)
assert.NoError(t, err)
assert.False(t, m)
}
func TestMinVersion(t *testing.T) {
c := testSpec(t)
c.Spec.CephVersion.AllowUnsupported = true
c.ClusterInfo = &client.ClusterInfo{Context: context.TODO()}
// All versions less than 15.2.0 or invalid tag are invalid
v := &cephver.CephVersion{Major: 15, Minor: 1, Extra: 999}
assert.Error(t, c.validateCephVersion(v))
v = &cephver.CephVersion{Major: 14}
assert.Error(t, c.validateCephVersion(v))
// All versions at least 15.2.0 are valid
v = &cephver.CephVersion{Major: 15, Minor: 2, Extra: 0}
assert.NoError(t, c.validateCephVersion(v))
v = &cephver.CephVersion{Major: 16}
assert.NoError(t, c.validateCephVersion(v))
}
func TestSupportedVersion(t *testing.T) {
c := testSpec(t)
c.ClusterInfo = &client.ClusterInfo{Context: context.TODO()}
// Supported versions are valid
v := &cephver.CephVersion{Major: 15, Minor: 2, Extra: 5}
assert.NoError(t, c.validateCephVersion(v))
// Supported versions are valid
v = &cephver.CephVersion{Major: 16, Minor: 2, Extra: 0}
assert.NoError(t, c.validateCephVersion(v))
// Unsupported versions are not valid
v = &cephver.CephVersion{Major: 17, Minor: 2, Extra: 0}
assert.Error(t, c.validateCephVersion(v))
// Unsupported versions are now valid
c.Spec.CephVersion.AllowUnsupported = true
assert.NoError(t, c.validateCephVersion(v))
}
func testSpec(t *testing.T) *cluster {
clientset := testop.New(t, 1)
context := &clusterd.Context{
Clientset: clientset,
}
return &cluster{Spec: &cephv1.ClusterSpec{}, context: context}
}