Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request to fix: node-tree-sitter won't work in electron render process #116

Closed
guidocalvano opened this issue Oct 30, 2022 · 1 comment

Comments

@guidocalvano
Copy link

Hey, I'm trying to use your awesome bindings in electron, but unfortunately I get complaints that it should not be non-context aware when run in the renderer process in electron. After digging through stack overflow I found this: electron/electron#18397 where they explain you can make a node library context aware simply by applying the very small change that I applied in my pull request. I tried to build the project myself, but that proved to be quite a lot of work, probably also because I am on an m1 mac. I haven't succeeded yet. Could you have a look at my pull request to see if it works? I could of course not test it given that I cannot yet build the project, even without any changes. The build in your ci/cd worked:

#115

@guidocalvano guidocalvano changed the title pull request to fix: node-tree-sitter won't work in render process pull request to fix: node-tree-sitter won't work in electron render process Oct 31, 2022
@guidocalvano
Copy link
Author

I went through a long process to get everything to work. I made new issue that details my steps and asks a few questions about them:
#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant