Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling overflow on realignment #3

Open
jcdang opened this issue Jul 21, 2018 · 0 comments
Open

Handling overflow on realignment #3

jcdang opened this issue Jul 21, 2018 · 0 comments

Comments

@jcdang
Copy link

jcdang commented Jul 21, 2018

I noticed that the current implementation doesn't handle new placements well when receiving a realignment. I started off with trendmicro's implementation but ended up rewriting a lot of it based on my needs. Here's the code for what I've done. Feel free to integrate any of it back in.

Gist

  • removed dependency on rc-align and used dom-align directly
  • handled placement realignment based on angle positioning of the popover and target

Thanks for the great work!
example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant