Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump moment to 2.29.4 in optionalDependencies #701

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: bump moment to 2.29.4 in optionalDependencies #701

wants to merge 1 commit into from

Conversation

richardkazuomiller
Copy link

Fixes #692

The order of the dependencies is changed because npm install --save-optional x puts dependencies in alphabetical order.

@richardkazuomiller richardkazuomiller mentioned this pull request Aug 24, 2022
Open
@richardkazuomiller
Copy link
Author

@trentm Are you interested in this update or shall we close it?

@hoangquanglam
Copy link

@trentm @richardkazuomiller , this might fix two SNYK issues: https://security.snyk.io/vuln/SNYK-JS-MOMENT-2440688 and https://security.snyk.io/vuln/SNYK-JS-MOMENT-2944238. Can't wait. Thanks.

@eexit
Copy link

eexit commented Nov 6, 2022 •
edited

Hello, any update on this?

Thanks!

Edit: I found a workaround:

yarn remove bunyan --save
yarn add bunyan --save --ignore-optionals
yarn list v1.22.18
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ moment@2.29.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update version of moment to fix GHSA-wc69-rhjr-hc9g (CVE-2022-31129)
3 participants
@richardkazuomiller @hoangquanglam @eexit