Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of moment to fix GHSA-wc69-rhjr-hc9g (CVE-2022-31129) #692

Open
otramony opened this issue Jul 7, 2022 · 8 comments · May be fixed by #701
Open

Update version of moment to fix GHSA-wc69-rhjr-hc9g (CVE-2022-31129) #692

otramony opened this issue Jul 7, 2022 · 8 comments · May be fixed by #701

Comments

@otramony
Copy link

otramony commented Jul 7, 2022

Please update the version of moment to 2.29.4 to fix security vulnerability and release a new tag.

https://nvd.nist.gov/vuln/detail/CVE-2022-31129
GHSA-wc69-rhjr-hc9g

@kirrg001
Copy link

@trentm How can we help to get a new Bunyan version out?
There is already a PR, which bumps moment #693

@markwbrown
Copy link

@otramony & @kirrg001 In the absence of @trentm approving PRs, you can override the version of momentjs bunyan depends upon by adding to your project's package.json:

"resolutions": { "moment": "2.29.4" }, "overrides": { "bunyan": { "moment": "2.29.4" } }

@trentm
Copy link
Owner

trentm commented Jul 23, 2022

Ug, sorry^10 all. Looking now.

@trentm
Copy link
Owner

trentm commented Jul 23, 2022

package-lock.json is not published to npm, so any npm install bunyan will get the newest 2.x version of moment.
Granted to there is a package-lock.json commited to the repo, so if there is a user cloning the repo and then npm installing from there, then they'll get the too-old version of moment. Have I missed a use case that any of you are hitting?

So, I'll merge the PR to update the package-lock.json file. However, is there a need for a new release tag or published version to npm for anyone? Please let me know if so.

My next inclination is to remove the package-lock.json file from the repo. My tendency more recently is to not have a package-lock.json file for library repos. Opinions vary. Anyway, I'll open a separate PR for that on which there can be discussion. We could always re-add the package-lock if there are strong enough uses for it.

trentm pushed a commit that referenced this issue Jul 23, 2022
trentm pushed a commit that referenced this issue Jul 23, 2022
@markwbrown
Copy link

I would appreciate a bumped version published to npm. As long as we're talking about it, I'd like to throw this idea out there: substituting dayjs for momentjs would be super awesome.

@trentm
Copy link
Owner

trentm commented Jul 23, 2022

I would appreciate a bumped version published to npm.

Why? It would be identical to the previous release (package-lock.json is not included in an npm published package).

substituting dayjs for momentjs would be super awesome.

Noted. I think there are issue(s) for that. #630 for one.

@xdivby0
Copy link

xdivby0 commented Aug 9, 2022

I would appreciate a bumped version published to npm.

Why? It would be identical to the previous release (package-lock.json is not included in an npm published package).

I'd appreciate it too. It would automatically be fixed for most people, now I had to manually look at what's exactly wrong and do
npm uninstall bunyan and npm install bunyan again so that moment is installed with a higher version number.

@richardkazuomiller
Copy link

Updating the optional dependency and releasing a new version will propagate updates to dependents and transitive dependents. I made a PR 🤠 #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants