Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request : support non-Amazon S3 targets such as minio by configuring aws session object #1393

Open
bkcsfi opened this issue Apr 14, 2023 · 4 comments
Labels
feature request Request for a new feature

Comments

@bkcsfi
Copy link

bkcsfi commented Apr 14, 2023

I would like to use the AWSS3 target with a generic S3 service, such as minio.

Would you please consider adding alternative endpoint configuration parameters, other than ARN?

Benthos for example, works with AWS and generic S3 services because it supports being able to independently specify:

  • region
  • endpoint
  • credentials.id
  • credentials.secret
  • credentials.token (optional)
  • (various other params)

Benthos also uses aws.session, but it creates the session with explicit parameters here

Whereas I think triggermesh creates an unconfigured session here

I'm not a go person, so this is just a guess.

Would you please consider allowing optional additional parameters that can be passed use when the session object is created, so that the s3 target can be used by other s3 providers?

@jmcx jmcx added the feature request Request for a new feature label Apr 24, 2023
@jmcx
Copy link
Contributor

jmcx commented Apr 24, 2023

Hi @bkcsfi, thanks for opening this.

This makes a lot of sense. Is there any chance you'd be available for a quick Zoom next week to help us better understand your use case and level of urgency of this request? You're welcome to DM me on our public Slack or reach me at jonathan@triggermesh.com.

@bkcsfi
Copy link
Author

bkcsfi commented Apr 24, 2023

Hi,

We worked around the issue using benthos, though that's a bit of a pain.

For us this is not an urgent feature request because we're just experimenting right now. I'm sorry, I don't think I could add much to this in a zoom meeting.

@jmcx
Copy link
Contributor

jmcx commented Apr 24, 2023

No problem, lets keep the issue open as a candidate for implementation.

@jmcx
Copy link
Contributor

jmcx commented Jun 1, 2023

@JeffNeff any chance you could take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants