Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapteroverride no work with autoscaling.knative.dev #1502

Open
chris93111 opened this issue Sep 18, 2023 · 0 comments
Open

Adapteroverride no work with autoscaling.knative.dev #1502

chris93111 opened this issue Sep 18, 2023 · 0 comments

Comments

@chris93111
Copy link

Hi the controller give this error when set autoscaling.knative.dev/min-scale in adapteroverride for webhooksource

{"severity":"ERROR","timestamp":"2023-09-18T19:54:17.639294166Z","logger":"triggermesh-controller","caller":"controller/controller.go:566","message":"Reconcile error","commit":"1360cec","knative.dev/controller":"github.com.triggermesh.triggermesh.pkg.sources.reconciler.webhooksource.Reconciler","knative.dev/kind":"sources.triggermesh.io.WebhookSource","knative.dev/traceid":"7603ad0d-c78c-491b-8cbd-8be9202d49e2","knative.dev/key":"cfg-events/test","duration":"25.352653ms","error":"failed to reconcile adapter: failed to synchronize adapter Service: Failed to update adapter Service \"webhooksource-test\": admission webhook \"validation.webhook.serving.knative.dev\" denied the request: validation failed: invalid key name \"autoscaling.knative.dev/min-scale\": metadata.annotations\nautoscaling annotations must be put under \"spec.template.metadata.annotations\" to work","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\tknative.dev/pkg@v0.0.0-20220818004048-4a03844c0b15/controller/controller.go:566\n...
{"severity":"INFO","timestamp":"2023-09-18T19:54:17.639601528Z","logger":"triggermesh-controller.event-broadcaster","caller":"record/event.go:285","message":"Event(v1.ObjectReference{Kind:\"WebhookSource\", Namespace:\"cfg-events\", Name:\"test\", UID:\"93ed6352-bf6d-4bc8-8d68-9ddbcc924207\", APIVersion:\"sources.triggermesh.io/v1alpha1\", ResourceVersion:\"1954323929\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedAdapterUpdate' Failed to update adapter Service \"webhooksource-test\": admission webhook \"validation.webhook.serving.knative.dev\" denied the request: validation failed: invalid key name \"autoscaling.knative.dev/min-scale\": metadata.annotations\nautoscaling annotations must be put under \"spec.template.metadata.annotations\" to work","commit":"1360cec"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant