-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: add row click event #2480
Comments
Hello @leosole-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to. Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR. |
@cjwinsor Let's look at this one tomorrow during standup. |
@leosole-trimble Can you provide your Did you need any visual indication that a row has been focused after the click, or expecting any other visual indications? You mention that it won't fire the event if the cell is editable, but what if some other cells are? |
@cjwinsor sure. |
I thought of just emitting the click if the cell clicked is not editable |
Prerequisites
Proposal
Emit a row click event when the user clicks a row (if the cell clicked is not editable)
Motivation and context
We need a way to direct the user to a detail page when clicking the row. Right now this is only possible through the icons at the end of the row, and our designers would like to have the click in the whole row, so we wouldn't need the extra column.
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
High
What product/project are you using Modus Components for ?
Trimble Inspections
What is your team/division name ?
Camaleão/Transportation
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
no
The text was updated successfully, but these errors were encountered: