Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: add row click event #2480

Open
2 tasks done
leosole-trimble opened this issue Apr 24, 2024 · 5 comments
Open
2 tasks done

Table: add row click event #2480

leosole-trimble opened this issue Apr 24, 2024 · 5 comments
Labels
external-request Bugs and features reported by individuals from other teams in Trimble priority:high Prioritization for this item is high

Comments

@leosole-trimble
Copy link
Contributor

leosole-trimble commented Apr 24, 2024

Prerequisites

Proposal

Emit a row click event when the user clicks a row (if the cell clicked is not editable)

Motivation and context

We need a way to direct the user to a detail page when clicking the row. Right now this is only possible through the icons at the end of the row, and our designers would like to have the click in the whole row, so we wouldn't need the extra column.

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

High

What product/project are you using Modus Components for ?

Trimble Inspections

What is your team/division name ?

Camaleão/Transportation

Are you willing to contribute ?

Yes

Are you using Modus Web Components in production ?

no

Copy link

Hello @leosole-trimble! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Apr 24, 2024
@enowak1031 enowak1031 added the priority:high Prioritization for this item is high label Apr 29, 2024
@enowak1031
Copy link

@cjwinsor Let's look at this one tomorrow during standup.

@cjwinsor
Copy link
Contributor

cjwinsor commented May 3, 2024

@leosole-trimble Can you provide your Motivation and context so we can better ensure that any changes we make to support this event meet your needs?

Did you need any visual indication that a row has been focused after the click, or expecting any other visual indications? You mention that it won't fire the event if the cell is editable, but what if some other cells are?

@leosole-trimble
Copy link
Contributor Author

@cjwinsor sure.
We do not need visual indicators after the click. Since there's already an option for highlighting the row on hover, an option to change the cursor to a pointer would be enough (not sure if it's already possible).
Our use case do not use editable cells, I just mentioned it because it could cause issues in other possible uses.

@leosole-trimble
Copy link
Contributor Author

I thought of just emitting the click if the cell clicked is not editable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-request Bugs and features reported by individuals from other teams in Trimble priority:high Prioritization for this item is high
Projects
Status: In Review
Development

No branches or pull requests

3 participants