Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modus-table] tableCore is called before it's initialized #2507

Open
2 tasks done
janwiebe-glasbergen opened this issue May 7, 2024 · 2 comments · May be fixed by #2532
Open
2 tasks done

[Modus-table] tableCore is called before it's initialized #2507

janwiebe-glasbergen opened this issue May 7, 2024 · 2 comments · May be fixed by #2532
Assignees
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@janwiebe-glasbergen
Copy link
Contributor

Prerequisites

Describe the issue

When using the modus table component an error occurs in the console:

TypeError: Cannot read properties of undefined (reading 'setState')
    at ModusTable.onDataChange (modus-table.entry.js:3931:24)
    at index-8e730124.js:1811:54
    at Array.map (<anonymous>)
    at setValue (index-8e730124.js:1808:34)
    at HostElement.set [as data] (index-8e730124.js:1859:25)
    at NoneEncapsulationDomRenderer.setProperty (platform-browser.mjs:645:17)
    at elementPropertyInternal (core.mjs:10980:18)
    at Module.ɵɵproperty (core.mjs:21752:9)

This seems to occur because the tableCore of the modus-table is used before it's intialized.

Reduced test cases

The issue is reproducible by going to https://modus-web-components.trimble.com/?path=/story/components-table--default and switch to the hover option
Bug

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.22.0

Priority

Medium

What product/project are you using Modus Components for ?

Nova / Construction calculation platform UI

What is your team/division name ?

ACDC

Are you willing to contribute ?

No

Are you using Modus Web Components in production ?

No response

@janwiebe-glasbergen janwiebe-glasbergen added the bug Something is wrong and needs to be addressed label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Hello @janwiebe-glasbergen! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label May 7, 2024
@sami-raboun
Copy link

@cjwinsor Any updates on this? We are also running into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: PR Review
3 participants