Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content Tree - Event handling for Ctrl+Click and Shift+ArrowKeys #1713

Open
2 tasks done
robert-nagy opened this issue Sep 11, 2023 · 4 comments · May be fixed by #2509
Open
2 tasks done

Content Tree - Event handling for Ctrl+Click and Shift+ArrowKeys #1713

robert-nagy opened this issue Sep 11, 2023 · 4 comments · May be fixed by #2509
Assignees
@prashanthr6383
Labels
1 1 story point bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus modus-tree-view team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology

Comments

@robert-nagy
Copy link

Prerequisites

Proposal

Currently the ContentTreeItem component handles the ItemClick event. We'd also like similar event handling for cases involving Ctrl+Click and Shift+ArrowKeys or a single event handler for when the selection is changed.

Motivation and context

In Creator we use the Content Tree to reflect the structure of the 3D object hiearachy in the in the viewer. Whenever we select an item in the ContentTree the same 3D object needs to be (de)selected. Single selection can be handled though the ItemClick event, but this does not handle cases where Ctrl+Click and Shift+ArrowKeys is used to select an item.
chrome_qqbmxBgSeT

What is the issue regarding ?

@trimble-oss/modus-web-components

Priority

Medium

What product/project are you using Modus Components for ?

Creator

What is your team/division name ?

Nexus

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

Not yet.
@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Sep 11, 2023
@msankaran0712
Copy link
Contributor

Maha to check with Robert for contribution

@msankaran0712 msankaran0712 added the modus-approved Reviewed and approved by Modus label Sep 13, 2023
@msankaran0712
Copy link
Contributor

hey @robert-nagy, wanted to check with you if are interested in contributing?

@msankaran0712 msankaran0712 added the team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology label Sep 15, 2023
@cjwinsor cjwinsor added the bug Something is wrong and needs to be addressed label Apr 3, 2024
@cjwinsor
Copy link
Contributor

cjwinsor commented Apr 3, 2024

  1. Shift+Arrow isn't firing itemClick event, and it should
  2. Ctrl+Click does fire the itemClick event, this should be double checked to make sure its working properly.

@robert-nagy Can you give more details about the Ctrl+Click scenario so I make sure I am reproducing correctly. When I Ctrl+Click, I am getting the itemClick event. I am not getting it when I do the Shift+Arrow though, which is a bug in my opinion. Can you clarify if adding the itemClick event on selection of an item via Shift+Arrow would solve your issue?

@cjwinsor cjwinsor changed the title ContentTree - Event handling for Ctrl+Click and Shift+ArrowKeys Content Tree - Event handling for Ctrl+Click and Shift+ArrowKeys Apr 3, 2024
@cjwinsor
Copy link
Contributor

Scope of this ticket has become: Shift + Arrow fires itemClick event

@cjwinsor cjwinsor added the 1 1 story point label Apr 25, 2024
@prashanthr6383 prashanthr6383 self-assigned this May 3, 2024
@prashanthr6383 prashanthr6383 linked a pull request May 8, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashanthr6383 prashanthr6383

Labels
1 1 story point bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble modus-approved Reviewed and approved by Modus modus-tree-view team-trimble-creator Team name: Nexus, Product names: Creator, RDK (Rapid Development Kit), Division: Trimble Technology
Projects
Modus Web Components
Status: PR Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Content Tree: event trigger on shift arrow keys trimble-oss/modus-web-components
4 participants
@cjwinsor @msankaran0712 @robert-nagy @prashanthr6383