Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modus Action Bar - Export ModusActionBarOptions interface #2511

Open
2 tasks done
Kai-Richardson opened this issue May 9, 2024 · 2 comments
Open
2 tasks done

Modus Action Bar - Export ModusActionBarOptions interface #2511

Kai-Richardson opened this issue May 9, 2024 · 2 comments
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble

Comments

@Kai-Richardson
Copy link

Prerequisites

Describe the issue

Right now, ModusActionBarOptions is not exported so we have to have a duplicate of the interface type.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

0.27.0-react18

Priority

Medium

What product/project are you using Modus Components for ?

Viewpoint Cascade

What is your team/division name ?

Cascade

Are you willing to contribute ?

Maybe

Are you using Modus Web Components in production ?

No response

@Kai-Richardson Kai-Richardson added the bug Something is wrong and needs to be addressed label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Hello @Kai-Richardson! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label May 9, 2024
@Kai-Richardson
Copy link
Author

Ah, I think what I'm seeing here is a strange duplicate export:
export { ModusActionBarOptions } from "./components/modus-action-bar/modus-action-bar";
export { ModusActionBarOptions as ModusActionBarOptions1 } from "./components/modus-action-bar/modus-action-bar";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble
Projects
Status: In Review
Development

No branches or pull requests

1 participant