Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModusFileDropzone: at the moment it doesnt support "accept" parameter to avoid users to upload any kind of files. #2003

Closed
2 tasks done
jmecosta opened this issue Jan 10, 2024 · 4 comments · Fixed by #2516
Closed
2 tasks done

ModusFileDropzone: at the moment it doesnt support "accept" parameter to avoid users to upload any kind of files. #2003

jmecosta opened this issue Jan 10, 2024 · 4 comments · Fixed by #2516
Assignees
@ElishaSamPeterPrabhu
Labels
2 2 story points bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble modus-file-dropzone

Comments

@jmecosta
Copy link

Prerequisites

Describe the issue

users are able to upload any kind of files causing problems in many difference scenarions.

Reduced test cases

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What is the issue regarding ?

@trimble-oss/modus-web-components

What version of npm package are you using ?

No response

Priority

High

What product/project are you using Modus Components for ?

Tekla Structures Launcher

What is your team/division name ?

Structures

Are you willing to contribute ?

No

Are you using Modus Web Components in production ?

No response
@jmecosta jmecosta added the bug Something is wrong and needs to be addressed label Jan 10, 2024
@github-actions GitHub Actions
Copy link

Hello @jmecosta! Thanks for opening an issue. The Modus core team will get back to you soon (usually within 24-hours) and provide guidance on how to proceed. Contributors are welcome to participate in the discussion and provide their input on how to best solve the issue, and even submit a PR if they want to.

Please wait until the issue is ready to be worked on before submitting a PR, or you can reach out to the core team if it is time bound. For trivial things, or bugs that don't change the expected behaviors and UI, you can go ahead and make a PR.

@github-actions github-actions bot added the external-request Bugs and features reported by individuals from other teams in Trimble label Jan 10, 2024
@rthanga1 rthanga1 added the refine Tickets to be refined or needs attention label Jan 11, 2024
@coliff
Copy link
Member

coliff commented Jan 17, 2024

Good suggestion. I'd imagine this would be relatively straight-forward to add too.

REF: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept

@jmecosta
Copy link
Author

jmecosta commented Jan 17, 2024 via email

@rthanga1 rthanga1 removed the refine Tickets to be refined or needs attention label Jan 24, 2024
@cjwinsor
Copy link
Contributor

cjwinsor commented May 3, 2024

Add an accept prop to the file upload component.

@cjwinsor cjwinsor added the 2 2 story points label May 3, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu self-assigned this May 10, 2024
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request May 10, 2024 that will close this issue
File Dropzone: Add accept property #2516
Merged
13 tasks
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu

Labels
2 2 story points bug Something is wrong and needs to be addressed external-request Bugs and features reported by individuals from other teams in Trimble modus-file-dropzone
Projects
Modus Web Components
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

File Dropzone: Add accept property trimble-oss/modus-web-components
5 participants
@jmecosta @cjwinsor @coliff @rthanga1 @ElishaSamPeterPrabhu