Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example with helper text on large inputs to Bootstrap #275

Closed
soniakaukonen opened this issue Feb 7, 2023 · 3 comments
Closed

Add an example with helper text on large inputs to Bootstrap #275

soniakaukonen opened this issue Feb 7, 2023 · 3 comments
Assignees
Labels
3 3 story points

Comments

@soniakaukonen
Copy link

soniakaukonen commented Feb 7, 2023

32 px input helper text 11 px semibold, 48 px input helper text 12 px semibold

@coliff coliff self-assigned this Feb 15, 2023
@coliff
Copy link
Member

coliff commented Feb 15, 2023

Could you please provide more details and specs on this request.
Are changes need to Modus Bootstrap or did you mean just add an example like the second one in this Codepen?
https://codepen.io/coliff/pen/LYJYXKO

@soniakaukonen
Copy link
Author

@coliff There was a font size change (font size was universally 10.5 regular and perceived too small). The final decision was 11px semibold for 32px inputs and 12px semibold for 48px inputs, so would require a change (and an example). We are in process of updating the UI kits. However, considering longer help text, I would still like to review the semibold weight of the text if that might not be too dominating.

@coliff
Copy link
Member

coliff commented Feb 15, 2023

Example demo updated here to preview with font-weight:600.
https://codepen.io/coliff/pen/LYJYXKO

The first one is font-size:11px (down from 12px) and the second is 12px. We don't use 11px anywhere else in Modus Bootstrap at all though.
Personally, I think it looks a bit too small and preferred it being 12px. (12px is the default 'small' size).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 3 story points
Projects
None yet
Development

No branches or pull requests

3 participants