Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a vertical rule helper class #90

Open
2 tasks done
coliff opened this issue Apr 13, 2022 · 0 comments
Open
2 tasks done

Add a vertical rule helper class #90

coliff opened this issue Apr 13, 2022 · 0 comments
Assignees
Labels
2 2 story points priority:medium

Comments

@coliff
Copy link
Member

coliff commented Apr 13, 2022

Prerequisites

Proposal

We sometimes need to use vertical rules in web apps and navbars. It'd be helpful to have a .vr vertical rule class in Modus Bootstrap. Bootstrap v5 has one so I propose that we port that over. The CSS for it is very small:

.vr {
  display: inline-block;
  align-self: stretch;
  width: 1px;
  min-height: 1em;
  background-color: currentColor;
  opacity: 0.25;
}

Motivation and context

I've used this on RouteReporter for some content in panels and the navbar to separate the Trimble logo and the app name. I'd like to use the same CSS/HTML on other webapps so I think it might make sense to add to Modus Bootstrap.

REF: https://github.com/twbs/bootstrap/blob/main/scss/helpers/_vr.scss
https://getbootstrap.com/docs/5.3/helpers/vertical-rule/

@coliff coliff self-assigned this Apr 13, 2022
@coliff coliff added the 2 2 story points label Apr 13, 2022
@coliff coliff added this to the Sprint 34 milestone Apr 13, 2022
@coliff coliff removed this from the Sprint 34 milestone Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 2 story points priority:medium
Projects
None yet
Development

No branches or pull requests

1 participant