Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding references for all button sizes to Style Guide #702

Open
soniakaukonen opened this issue Aug 31, 2023 · 6 comments
Open

Add padding references for all button sizes to Style Guide #702

soniakaukonen opened this issue Aug 31, 2023 · 6 comments

Comments

@soniakaukonen
Copy link
Contributor

soniakaukonen commented Aug 31, 2023

Style guide is missing an illustration of padding in buttons with icon left/right (styles).

@soniakaukonen
Copy link
Contributor Author

Refer to XD, note mistake in small icon without icons should be 12 instead of 8px.

Image

@coliff
Copy link
Member

coliff commented Sep 1, 2023

This will be (partially?) addressed with the new site template which uses a much better way of displaying the specs automatically... here's a screen grab:

image

Do you think that will suffice? it uses Popover CSS Inspector, a JavaScript library which I created recently. More demos at: https://coliff.github.io/popover-css-inspector/

@soniakaukonen
Copy link
Contributor Author

Looks good, that would save us lots of manual work. The only issue is to get an example of:

  • text only
  • button left and text
  • text and button right
    @coliff

@coliff
Copy link
Member

coliff commented Sep 1, 2023

good feedback. I`ll look to get them added.

@enowak1031
Copy link
Collaborator

@coliff How are we doing on this? I'm inclined to close as not planned.

@coliff
Copy link
Member

coliff commented Oct 23, 2023

I think this should be left open. We should add specs as popovers as suggested by Sonia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants