Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to automatically work out delimiter on import? #26

Open
caro401 opened this issue Dec 19, 2023 · 1 comment
Open

Attempt to automatically work out delimiter on import? #26

caro401 opened this issue Dec 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@caro401
Copy link
Collaborator

caro401 commented Dec 19, 2023

The errors you get when the delimiter is incorrectly set can be really confusing for users. We can have a pretty good idea of what the first (header) row of an import CSV should look like, because we specify in the plugin docs what this has to look like.

I think we might be able to help users by checking that parsing the first/header line with the provided delimiter gives a correct-looking result, and if not give the user a clear error message saying we think the delimiter setting might be wrong, and suggest what we think it should be and how to change that setting.

I don't think we should get rid of the existing configuration option or the default value ,, since this is also used when exporting. We should however make the docs about this setting more prominent

@flachware does this correctly summarise our earlier discussion?

@caro401 caro401 added the enhancement New feature or request label Dec 19, 2023
@flachware
Copy link
Collaborator

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants