Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(v9): invalidation filters not applying on interop procedures #3460

Closed
juliusmarminge opened this issue Dec 22, 2022 · 1 comment
Closed

Comments

@juliusmarminge
Copy link
Member

juliusmarminge commented Dec 22, 2022

not sure why it's failing but cba fixing this right now - is it necessary to fix this for interop? I doubt anyone will notice it not working if they haven't already xd

Originally posted by @juliusmarminge in #3302 (comment)

Goal

Make this test pass again:

Background

We got some regression in #3455 about the invalidation filters not working properly. Got fixed for v10 in #3302 but didn't bother fixing the interop.

It's probably due to some transformation in the querykey, since we go back and forth between the array and dot-separated-string format to make sure the interop stuff is working

@KATT KATT changed the title bug: invalidation filters not applying on interop procedures v9 bug: invalidation filters not applying on interop procedures Dec 22, 2022
@KATT KATT changed the title v9 bug: invalidation filters not applying on interop procedures bug(v9): invalidation filters not applying on interop procedures Dec 22, 2022
@juliusmarminge
Copy link
Member Author

nvm fixed it in the original pr 943fdeb

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant