Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

mkdirp@0.5.1 is no longer supported... #2990

Closed
metaverde opened this issue Apr 21, 2020 · 10 comments
Closed

mkdirp@0.5.1 is no longer supported... #2990

metaverde opened this issue Apr 21, 2020 · 10 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@metaverde
Copy link

First, I super-appreciate the Truffle team and Truffle.
Thank-you for all you do.

I apologize if this has already been raised.
I scrolled around and did not see it.

  • [X ] I've asked for help in the Truffle Gitter before filing this issue.

Yes. Additionally the same issue was raised earlier and not addressed.
It is also an issue with netlify/cli as well as some other repositories.


Issue

I get this warning when I install Truffle using the npm install -g truffle command:

npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

Steps to Reproduce

All I have to do to get this is to install Truffle.

Expected Behavior

I would expect at the least to be able to find how to update/upgrade to the proper mkdirp.
I realize this is not the fault of the Truffle team in any way.

Actual Results

I google and search and cannot find how to update/upgrade/install new mkdirp.
I have not yet used the Truffle to see if there are issues with it.
The warning says the API surface has changed to use Promises in 1.x., so I anticipate there will be issues?

Environment

  • Operating System: Ubuntu 18.04, aws ec2 instance
  • Ethereum client: not yet installed
  • Truffle version (truffle version): 5.1.22
  • node version (node --version): v10.20.1
  • npm version (npm --version): 6.14.4
@eggplantzzz
Copy link
Contributor

Thanks @metaverde for bringing this up! It would be good to see if we can bump this.

@eggplantzzz eggplantzzz added the dependencies Pull requests that update a dependency file label Apr 21, 2020
@eggplantzzz
Copy link
Contributor

eggplantzzz commented Apr 28, 2020

@metaverde In the last version of Truffle (5.1.23) mkdir was removed. Happy day! Thanks again for creating the issue.

@fudingyu
Copy link

@metaverde In the last version of Truffle (5.1.23) mkdir was removed. Happy day! Thanks again for creating the issue.

But when I install Truffle occur same problem

npm install truffle -g
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
C:\Users\xxxx\AppData\Roaming\npm\truffle -> C:\Users\xxx\AppData\Roaming\npm\node_modules\truffle\build\cli.bundled.js

truffle@5.1.32 postinstall C:\Users\xxx\AppData\Roaming\npm\node_modules\truffle
node ./scripts/postinstall.js

  • truffle@5.1.32
    updated 1 package in 125.381s

@CruzMolina
Copy link
Contributor

@fudingyu If you run npm uninstall -g truffle && npm install -g truffle do you still see that error?

I've tried replicating the error on node versions v8.x, v10.x, & v12.x, but have not seen that deprecation message.

@fudingyu
Copy link

fudingyu commented Jul 3, 2020

Environment
Operating System:Windows 10
Ethereum client:
Truffle version (Truffle v5.1.32):
node version (v14.4.0):
npm version (6.14.5):
/////////////////////////////

npm uninstall -g truffle
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
removed 27 packages in 1.212s
/////////////////////////////

npm install -g truffle
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
C:\Users\xxx\AppData\Roaming\npm\truffle -> C:\Users\xxx\AppData\Roaming\npm\node_modules\truffle\build\cli.bundled.js

truffle@5.1.33 postinstall C:\Users\xxx\AppData\Roaming\npm\node_modules\truffle
node ./scripts/postinstall.js

  • truffle@5.1.33
    added 27 packages from 439 contributors in 18.706s

@CruzMolina
Copy link
Contributor

Thanks for sharing that @fudingyu !

Looks like mocha, one of truffle's external dependencies, is puling in this older version of mkdirp.

https://github.com/trufflesuite/truffle/blob/develop/packages/truffle/package.json#L30
https://github.com/mochajs/mocha/blob/v5.2.0/package.json#L470

@CruzMolina CruzMolina reopened this Jul 3, 2020
@Peter197903
Copy link

Got the same issue here. clean install under a fresh windows 10 machine

C:\Windows\System32>truffle version
Truffle v5.1.33 (core: 5.1.33)
Solidity v0.5.16 (solc-js)
Node v14.5.0
Web3.js v1.2.1

@eggplantzzz
Copy link
Contributor

eggplantzzz commented Jul 6, 2020

I think it is a warning from a dependency that has mkdirp as a dependency. I'm not sure we can do much about that I guess :)

Update: Oops I see that Cruz already mentioned this. I think we have an effort right now going on to update Mocha.

@eggplantzzz
Copy link
Contributor

I'm going to close this for maintenance. Truffle has removed mkdirp as a direct dependency which is about as much as we can do for now. Eventually I suppose some of Truffle's dependencies will get off of mkdirp as well. Thanks everyone!

@CruzMolina
Copy link
Contributor

CruzMolina commented Jul 9, 2020

@metaverde @fudingyu @Peter197903 This should have been resolved by #3146 . The next official release should be out later today, but if you'd like to test this ASAP, feel free to give npm i truffle@next a shot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

5 participants