Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for Signed-Off-By line in upgrade action #238

Merged

Conversation

puzzler7
Copy link
Collaborator

@puzzler7 puzzler7 commented May 7, 2024

Adds support for adding a Signed-Off-By line to commits created by the upgrade action, as requested here.

Tested in this repo, you can see the commit here.

puzzler7 added 2 commits May 7, 2024 14:13
Copy link
Contributor

@det det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

puzzler7 added 3 commits May 7, 2024 16:18
@puzzler7 puzzler7 changed the title WIP: feat: add option for Signed-Off-By line in upgrade action feat: add option for Signed-Off-By line in upgrade action May 8, 2024
@puzzler7 puzzler7 requested a review from TylerJang27 May 8, 2024 00:15
@puzzler7 puzzler7 merged commit bd68632 into main May 8, 2024
37 of 40 checks passed
@puzzler7 puzzler7 deleted the maverick/trunk-11279-support-signed-commits-for-upgrade-action branch May 8, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants