New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minification of some javascript is breaking some functionality. #750
Comments
A note from further testing: it seems that with |
I am not sure what the exact problem is. I do recall issues where the JS file was actually a module JS file. That can make a difference. For that you would need to set Trunk uses https://github.com/wilsonzlin/minify-js for JS minification (we use 0.5.6, as 0.6.0 also had some issues). So it would make sense to open an issue on that project. |
I am not sure if there's something that trunk could do better? If so, please let me know. |
Sorry for not replying sooner. Adding highlighting-b62b1cbd3f28dbb8.js:1 Uncaught TypeError: Cannot read properties of undefined (reading 'init')
at highlighting-b62b1cbd3f28dbb8.js:1:19 I'll also open an issue over there when I find some time, but I am leaving this here for posterity's sake. |
Running into some issues adding javascript to an app. Without minification, you get
Which seems to be a result of minification.
I've created a relatively minimal reproduction here.
Changing
to
during a release build (otherwise modification in general is disabled) solves the problem.
The text was updated successfully, but these errors were encountered: