Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract detector into it's own artifact #56

Open
aalmiray opened this issue Mar 2, 2021 · 1 comment
Open

Extract detector into it's own artifact #56

aalmiray opened this issue Mar 2, 2021 · 1 comment

Comments

@aalmiray
Copy link

aalmiray commented Mar 2, 2021

First off, I love this plugin! I use its detector API in non-maven scenarios:

It'd be great if the Detector API (Detector, providers, and exception) were to be found in its own artifact. That way other non-maven consumers can use it as is, without having to exclude Maven dependencies. The os-maven-plugin project would have to migrate to a multi-project build so that the plugin consumes the library and releases stay in sync.

An additional benefit would be to transform the library into a full module. No worries, it can stay in Java 8 if the https://github.com/moditect/moditect plugin is used to generate the module descriptor.

I can contribute patches 😄

@aalmiray
Copy link
Author

Any thoughts on this? Would contribute a PR if given the green light 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant