{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":528582593,"defaultBranch":"main","name":"nova","ownerLogin":"trynova","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-08-24T20:23:44.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/108045716?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717005651.0","currentOid":""},"activityList":{"items":[{"before":"e95a258e0e7e279cd871c555e7c27a081bb1bb14","after":"d289ea154d51600227fbba6ba41f3b84c2ade3e5","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-29T19:35:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(ecmascript): Colocate Function heap impls","shortMessageHtmlLink":"chore(ecmascript): Colocate Function heap impls"}},{"before":"88884c84b427f73a0cc395a6149b5b524bd5a75e","after":"e95a258e0e7e279cd871c555e7c27a081bb1bb14","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-29T18:47:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(ecmascript): Colocate Number heap impls","shortMessageHtmlLink":"chore(ecmascript): Colocate Number heap impls"}},{"before":"5796f9971681ed0a9739fa90c2de8122c27b5c43","after":"88884c84b427f73a0cc395a6149b5b524bd5a75e","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-29T18:25:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(ecmascript): Colocate String heap impls","shortMessageHtmlLink":"chore(ecmascript): Colocate String heap impls"}},{"before":null,"after":"5796f9971681ed0a9739fa90c2de8122c27b5c43","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-29T18:00:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(ecmascript): Colocate BigInt heap impls","shortMessageHtmlLink":"chore(ecmascript): Colocate BigInt heap impls"}},{"before":"ed2eb0b10a7419e0b2bd8d3910214714cafe8493","after":null,"ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-28T19:51:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"}},{"before":"095fd97e8893b268f620f83bf3990d3897124b38","after":"d27e90643157f115b80616c526c4f632717941f5","ref":"refs/heads/main","pushedAt":"2024-05-28T19:51:27.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"Feat/heap types cleanup (#206)\n\n* chore(heap): Clean up HeapMarkAndSweep trait\r\n\r\n* chore(ecmascript): Colocate Array heap impls with Array\r\n\r\n* chore(ecmascript): Colocate OrdinaryObject heap impls\r\n\r\n* fmt","shortMessageHtmlLink":"Feat/heap types cleanup (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321798673\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/206\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/206/hovercard\" href=\"https://github.com/trynova/nova/pull/206\">#206</a>)"}},{"before":"1153c6dcce602dea782caee5b6cfeb3ef3a0336d","after":"ed2eb0b10a7419e0b2bd8d3910214714cafe8493","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-28T19:49:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"fmt","shortMessageHtmlLink":"fmt"}},{"before":null,"after":"1153c6dcce602dea782caee5b6cfeb3ef3a0336d","ref":"refs/heads/feat/heap-types-cleanup","pushedAt":"2024-05-28T19:45:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(ecmascript): Colocate OrdinaryObject heap impls","shortMessageHtmlLink":"chore(ecmascript): Colocate OrdinaryObject heap impls"}},{"before":"ebfaa41cec9eb8da8db894fae15b20be29e41f02","after":"095fd97e8893b268f620f83bf3990d3897124b38","ref":"refs/heads/main","pushedAt":"2024-05-28T18:34:57.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(nova_cli): Print parse errors (#205)","shortMessageHtmlLink":"feat(nova_cli): Print parse errors (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321687240\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/205\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/205/hovercard\" href=\"https://github.com/trynova/nova/pull/205\">#205</a>)"}},{"before":"b423b578e6942867bf6349d439b9c08af56a045b","after":"83bae8e70b93a5438aebda733fbc49a1648f41fe","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-28T18:10:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"Heap GC adaptations etc","shortMessageHtmlLink":"Heap GC adaptations etc"}},{"before":"519dbcb217ff4937c6ecbaa2ad050b842034b636","after":"ebfaa41cec9eb8da8db894fae15b20be29e41f02","ref":"refs/heads/main","pushedAt":"2024-05-28T14:15:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(nova_cli): Allow running multiple files (#204)","shortMessageHtmlLink":"feat(nova_cli): Allow running multiple files (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321183292\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/204\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/204/hovercard\" href=\"https://github.com/trynova/nova/pull/204\">#204</a>)"}},{"before":"a8b9929997543928d26822b18630044ea2706a40","after":"519dbcb217ff4937c6ecbaa2ad050b842034b636","ref":"refs/heads/main","pushedAt":"2024-05-28T06:41:11.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(nova_cli): Print uncaught exceptions (#203)\n\nThis patch prints a string representation of an uncaught exception in\r\n`nova_cli eval` before exiting the process with error code 1.\r\n\r\nSince the `ToString()` operation is not guaranteed to succeed, this\r\ninstead adds a `Value::string_repr` which never returns `Err`, and\r\nwhich accounts for symbols as well as objects whose stringification\r\nthrows.","shortMessageHtmlLink":"feat(nova_cli): Print uncaught exceptions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2320204363\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/203\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/203/hovercard\" href=\"https://github.com/trynova/nova/pull/203\">#203</a>)"}},{"before":"17e51bdc0f2e240c6596e3b0e10083148246b9f6","after":"a8b9929997543928d26822b18630044ea2706a40","ref":"refs/heads/main","pushedAt":"2024-05-28T06:25:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(nova_vm): Add symbol descriptive strings (#202)","shortMessageHtmlLink":"feat(nova_vm): Add symbol descriptive strings (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2320196035\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/202\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/202/hovercard\" href=\"https://github.com/trynova/nova/pull/202\">#202</a>)"}},{"before":"0c31db122733c088f8b9b1baf032e6103c649e4a","after":"b423b578e6942867bf6349d439b9c08af56a045b","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-27T19:08:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"AbstractClosure, more promise work and so forth","shortMessageHtmlLink":"AbstractClosure, more promise work and so forth"}},{"before":"429b55088153d6aaf66344375e0221034e06aa60","after":"17e51bdc0f2e240c6596e3b0e10083148246b9f6","ref":"refs/heads/main","pushedAt":"2024-05-27T06:44:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(nova_cli): Add a `print` global function (#200)\n\nIn order to implement this, this patch also publicly exposes `Realm`\r\n(since using that type is needed to call\r\n`initialize_host_defined_realm`), and it also adds a public\r\n`Value::to_string` method.","shortMessageHtmlLink":"feat(nova_cli): Add a <code>print</code> global function (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318277740\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/200\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/200/hovercard\" href=\"https://github.com/trynova/nova/pull/200\">#200</a>)"}},{"before":"decfebde1020779a9031b4bc1bca14de4d557ad3","after":"429b55088153d6aaf66344375e0221034e06aa60","ref":"refs/heads/main","pushedAt":"2024-05-27T06:41:38.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"fix(nova_cli): Fix the `--verbose` flag (#201)\n\nThis flag was introduced in #199, but it mistakenly did nothing. This\r\npatch fixes that.","shortMessageHtmlLink":"fix(nova_cli): Fix the <code>--verbose</code> flag (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318281743\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/201\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/201/hovercard\" href=\"https://github.com/trynova/nova/pull/201\">#201</a>)"}},{"before":"22ded295c794d15917ffae10e148932787352b08","after":"decfebde1020779a9031b4bc1bca14de4d557ad3","ref":"refs/heads/main","pushedAt":"2024-05-27T05:03:21.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore(nova_cli): Don't print debug information by default (#199)\n\nTo reenable printing that information, this patch also adds a\r\n`--verbose` flag to `nova_cli`.","shortMessageHtmlLink":"chore(nova_cli): Don't print debug information by default (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2318236644\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/199\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/199/hovercard\" href=\"https://github.com/trynova/nova/pull/199\">#199</a>)"}},{"before":"e1340408587f0cd94ff6d8e476ad5afa41025ef5","after":"0c31db122733c088f8b9b1baf032e6103c649e4a","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-26T06:56:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"ModuleEnvironments, quite a bit of other work","shortMessageHtmlLink":"ModuleEnvironments, quite a bit of other work"}},{"before":"d07c062ed21a41520f7b643955daeacbee86a3d6","after":null,"ref":"refs/heads/chore/oxc-update","pushedAt":"2024-05-25T09:18:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"}},{"before":"558f1c0ebf655f8e742456ff47137d01b06ba2f6","after":"22ded295c794d15917ffae10e148932787352b08","ref":"refs/heads/main","pushedAt":"2024-05-25T09:18:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore: Update oxc (#198)","shortMessageHtmlLink":"chore: Update oxc (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2306536564\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/198\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/198/hovercard\" href=\"https://github.com/trynova/nova/pull/198\">#198</a>)"}},{"before":"f0cfbbfb8da3103db91e29b799654776dd663098","after":"e1340408587f0cd94ff6d8e476ad5afa41025ef5","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-23T19:19:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"More work around Promises, module environments","shortMessageHtmlLink":"More work around Promises, module environments"}},{"before":"d02fe6fbd7092142fe853a7662d0444586ddc81a","after":"f0cfbbfb8da3103db91e29b799654776dd663098","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-21T20:51:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"ResolveExport and mostly fix ParseModule","shortMessageHtmlLink":"ResolveExport and mostly fix ParseModule"}},{"before":"63ecfee59174001fc6419e8ce6c53a4682266753","after":"d02fe6fbd7092142fe853a7662d0444586ddc81a","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-20T19:36:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"fix errors in cyclic_module_records and fmt","shortMessageHtmlLink":"fix errors in cyclic_module_records and fmt"}},{"before":"417334e181b4f67bd250ba42a1163a8d7ed8e164","after":"63ecfee59174001fc6419e8ce6c53a4682266753","ref":"refs/heads/feat/ecmascript-modules","pushedAt":"2024-05-20T18:53:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"Abstract closures, Promises, and such work","shortMessageHtmlLink":"Abstract closures, Promises, and such work"}},{"before":"2b26424fb90318b9310f43b150eea40d6ed059cb","after":"d07c062ed21a41520f7b643955daeacbee86a3d6","ref":"refs/heads/chore/oxc-update","pushedAt":"2024-05-20T18:32:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore: Update oxc","shortMessageHtmlLink":"chore: Update oxc"}},{"before":null,"after":"2b26424fb90318b9310f43b150eea40d6ed059cb","ref":"refs/heads/chore/oxc-update","pushedAt":"2024-05-20T18:29:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"chore: Update oxc","shortMessageHtmlLink":"chore: Update oxc"}},{"before":"af65d91eeeb0a869a3ce100ee6f7584c112a4c79","after":"558f1c0ebf655f8e742456ff47137d01b06ba2f6","ref":"refs/heads/main","pushedAt":"2024-05-19T22:10:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(ecmascript): Implement the `this` keyword (#197)\n\nThis patch also fixes a bug in which functions created with the\r\n`InstantiateOrdinaryFunctionExpression` bytecode instruction were\r\ncreated with a lexical this mode, when it should be either strict or\r\nglobal. The lexical this mode is only used for arrow functions, and it\r\ncauses the `this` resolution to be wrong in other functions.","shortMessageHtmlLink":"feat(ecmascript): Implement the <code>this</code> keyword (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304782453\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/197\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/197/hovercard\" href=\"https://github.com/trynova/nova/pull/197\">#197</a>)"}},{"before":"cf339e13aeb18bec24fbe50c8248650140d4b3cc","after":"af65d91eeeb0a869a3ce100ee6f7584c112a4c79","ref":"refs/heads/main","pushedAt":"2024-05-19T22:06:30.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(ecmascript): Allow constructing ECMAScript functions (#196)\n\nAs part of making this work, this patch merges the internal slots\r\n`[[ConstructorKind]]` and `[[IsClassConstructor]]`, as well as the\r\npresence or absence of the `[[Construct]]` internal method (which\r\nhadn't been implemented in Nova yet) into a single `ConstructorStatus`\r\nenum.\r\n\r\nCo-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>","shortMessageHtmlLink":"feat(ecmascript): Allow constructing ECMAScript functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304777780\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/196\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/196/hovercard\" href=\"https://github.com/trynova/nova/pull/196\">#196</a>)"}},{"before":"498ea48532eec5b3ae733c8c11c56d0aa63dd6d0","after":"cf339e13aeb18bec24fbe50c8248650140d4b3cc","ref":"refs/heads/main","pushedAt":"2024-05-19T20:08:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"andreubotella","name":"Andreu Botella","path":"/andreubotella","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8225977?s=80&v=4"},"commit":{"message":"feat(ecmascript): Allow object creation with a different prototype (#195)\n\nPer the spec, OrdinaryCreateFromConstructor should get the `prototype`\r\nproperty of the passed constructor, and if that is an object, it\r\nshould create a new object whose prototype is that property;\r\notherwise, the prototype would be set to the passed intrinsic default\r\nprototype.\r\n\r\nIn the current implementation of this method, the `prototype` of the\r\npassed constructor is obtained, but then it is ignored. The given\r\nintrinsic default prototype is used to determine in which heap to\r\nstore the object, which gives it the right default prototype, but\r\nit does not check whether the constructor's `prototype` property\r\nmatches that default prototype.\r\n\r\nIt seems like this gets the right result for all of the times where\r\nNova currently does object construction. However, allowing creating an\r\nobject with a prototype different from the heap's default would be\r\nneeded for constructing ECMAScript functions.\r\n\r\nAs part of that, this patch changes `get_prototype_from_constructor`\r\nto return a `JsResult<Option<Object>>`, guaranteeing that it will not\r\ngive the caller an object which is the `ProtoIntrinsics`'s\r\ncorresponding prototype. It also changes\r\n`ordinary_object_create_with_intrinsics` to take an optional prototype\r\nobject aside from the optional `ProtoIntrinsics`.\r\n\r\nIt also changes `ordinary_create_from_constructor` to use the\r\nprototype obtained from the constructor, as well as to remove the\r\n`_internal_slots_list` parameter. In the spec this parameter is used\r\nto create the object with the right internal slots, but in Nova the\r\nequivalent of this is choosing in which heap the object is created,\r\nwhich the `ProtoIntrinsics` argument already does.","shortMessageHtmlLink":"feat(ecmascript): Allow object creation with a different prototype (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304746496\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/195\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/195/hovercard\" href=\"https://github.com/trynova/nova/pull/195\">#195</a>"}},{"before":"eb097bbc872d6b1c8e2bb10705d8cc81e5feabb8","after":"498ea48532eec5b3ae733c8c11c56d0aa63dd6d0","ref":"refs/heads/main","pushedAt":"2024-05-19T14:10:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aapoalas","name":"Aapo Alasuutari","path":"/aapoalas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19621382?s=80&v=4"},"commit":{"message":"fix(ecmascript): Add a missing `#[test]` annotation (#194)","shortMessageHtmlLink":"fix(ecmascript): Add a missing <code>#[test]</code> annotation (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2304628005\" data-permission-text=\"Title is private\" data-url=\"https://github.com/trynova/nova/issues/194\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/trynova/nova/pull/194/hovercard\" href=\"https://github.com/trynova/nova/pull/194\">#194</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEV1HvtwA","startCursor":null,"endCursor":null}},"title":"Activity · trynova/nova"}