Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaos: improve crealeElement function #850

Merged
merged 1 commit into from
Apr 24, 2023
Merged

chaos: improve crealeElement function #850

merged 1 commit into from
Apr 24, 2023

Conversation

kamiazya
Copy link
Member

@kamiazya kamiazya commented Apr 24, 2023

Changes

  • Make children non-mandatory in createElement function so that ASTs can be generated with a smaller amount of code.
  • Modified to give priority to the location of props passed in the createElement function.
  • The type parameter is now accepted when creating an AttributeASTNode with the createElement function.
  • Fixed an issue with incorrect SmoothType type

@kamiazya kamiazya self-assigned this Apr 24, 2023
@kamiazya kamiazya changed the title fix: improve crealeElement function chaos: improve crealeElement function Apr 24, 2023
@kamiazya kamiazya merged commit 39dd9d4 into main Apr 24, 2023
7 checks passed
@kamiazya kamiazya deleted the fix-ast-builder branch April 24, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant