Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for CI #87

Open
Newbie012 opened this issue Oct 17, 2022 · 3 comments
Open

Add documentation for CI #87

Newbie012 opened this issue Oct 17, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Newbie012
Copy link
Collaborator

I should probably add basic documentation of how to run SafeQL in CI

@karlhorky
Copy link
Collaborator

karlhorky commented Oct 26, 2022

@Newbie012
Copy link
Collaborator Author

Interesting... I'm using the following service for the CI in the project:

jobs:
  check:
    runs-on: ubuntu-latest
    services:
      postgres:
        image: postgres:14
        env:
          POSTGRES_USER: postgres
          POSTGRES_PASSWORD: postgres
          POSTGRES_DB: postgres
        ports:
          - 5432:5432
        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5

I'm not sure what's the better approach here.

@karlhorky
Copy link
Collaborator

Seems like your approach offers a bit more configurability, but may be a bit slower to start.

@Newbie012 Newbie012 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants