Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin 1.9.20 #390

Closed
drewhamilton opened this issue Sep 12, 2023 · 12 comments
Closed

Support Kotlin 1.9.20 #390

drewhamilton opened this issue Sep 12, 2023 · 12 comments

Comments

@drewhamilton
Copy link

1.9.20-Beta appears to remove the setUseIR function, so tests crash at runtime.

'void org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments.setUseIR(boolean)'
java.lang.NoSuchMethodError: 'void org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments.setUseIR(boolean)'
	at com.tschuchort.compiletesting.KotlinCompilation$commonK2JVMArgs$1.invoke(KotlinCompilation.kt:304)
	at com.tschuchort.compiletesting.KotlinCompilation$commonK2JVMArgs$1.invoke(KotlinCompilation.kt:279)
	at com.tschuchort.compiletesting.AbstractKotlinCompilation.commonArguments(AbstractKotlinCompilation.kt:172)
	at com.tschuchort.compiletesting.KotlinCompilation.commonK2JVMArgs(KotlinCompilation.kt:279)
	at com.tschuchort.compiletesting.KotlinCompilation.compileJvmKotlin(KotlinCompilation.kt:452)
	at com.tschuchort.compiletesting.KotlinCompilation.compile(KotlinCompilation.kt:628)
	at dev.drewhamilton.poko.PokoCompilerPluginTest.compilation of valid class succeeds(PokoCompilerPluginTest.kt:221)
@martinbonnin
Copy link

Can you try with this branch? #388

@apatrida
Copy link

This is likely to tail from branch #388 still:

args.useIR = useIR
Screenshot 2023-09-26 at 5 57 10 AM

I think this is now inferred as the opposite of useOldBackend in the compiler code.

@drewhamilton
Copy link
Author

@martinbonnin Yep, my tests pass if I do an includeBuild with #388's branch.

@3flex
Copy link
Contributor

3flex commented Oct 8, 2023

Testing of #394 which is a slightly more complete PR would be appreciated too if anyone has the chance.

@drewhamilton
Copy link
Author

Yep, confirmed #394's branch works for me too.

@krzema12
Copy link

krzema12 commented Nov 5, 2023

Is there any traction in this ticket? My tests are failing on 1.9.20. @tschuchortdev

@martinbonnin
Copy link

@krzema12 until support gets added upstream you can use @ZacSweers fork that should have much better support for newer versions of Kotlin: https://github.com/ZacSweers/kotlin-compile-testing

@ftomassetti
Copy link

Also running in this issue. It would be nice to get a new release with support for 1.9.20

@wangk5
Copy link
Contributor

wangk5 commented Jan 3, 2024

Also running into this issue! Is there an estimate for when we'll get the new release to support 1.9.20?

@NinjaCookie84
Copy link

Also running into this issue. Would love to see progress here. Any way to help speed this up? (Not sure if I can though)

@frecco75
Copy link

@krzema12 until support gets added upstream you can use @ZacSweers fork that should have much better support for newer versions of Kotlin: https://github.com/ZacSweers/kotlin-compile-testing

Is it possible to make a Pull Request on this repo or the code base has changed a lot?

@tschuchortdev
Copy link
Owner

I have just made a new release updated for Kotlin v1.9.24 and with a bunch of bug fixes cherrypicked from forks: https://github.com/tschuchortdev/kotlin-compile-testing/releases/tag/1.6.0

As for Kotlin v2.0.0, I've taken a look at it and it seems to be a lot of work with changes in both KAPT and KSP as I can see from the work that Zac Sweers has already done on this. I'll see if I can merge changes from his fork back later so they don't diverge too much. Honestly, you're probably better off using Zac Sweers' fork if you need quick updates. I'm doing Scala work nowadays and don't really use this myself anymore, so my motivation to spend scarce free time on maintenance is dwindling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants