Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinity / rate 0 not working? #619

Open
unusualevent opened this issue May 16, 2023 · 4 comments
Open

infinity / rate 0 not working? #619

unusualevent opened this issue May 16, 2023 · 4 comments

Comments

@unusualevent
Copy link

Version and Runtime

as of 27f553fe091151234f899866bc8ee0072be0c9b5 (latest go install github.com/tsenart/vegeta@latest)

Expected Behaviour

per docs, something about --rate=infinity or --rate=0

Actual Behaviour

something about it being undefined

invalid value "infinity" for flag -rate: strconv.Atoi: parsing "infinity": invalid syntax
2023/05/15 21:12:59 rate frequency and time unit must be bigger than zero

Steps to Reproduce

echo "GET https://example.com" | vegeta attack -duration=5s -connections=100 -rate=0/0s | tee results.bin | vegeta report

Additional Context

#423 <- feature introuced here?

@tsenart
Copy link
Owner

tsenart commented May 18, 2023 via email

@unusualevent
Copy link
Author

So then this line is dead code I'm guessing: https://github.com/tsenart/vegeta/blob/27f553fe091151234f899866bc8ee0072be0c9b5/flags.go#LL68C1-L68C1

And there's two spots to change in the docs, the markdown and the help output.

0.0n or "0.On" seems reeeeaaally specific

@unusualevent
Copy link
Author

what you suggested doesn't work. echo "GET https://example.com" | vegeta attack -duration=5s -rate=0.0n (or 0.0s, or 0.Os, or 0.0, etc etc

@tsenart
Copy link
Owner

tsenart commented May 18, 2023

Sorry that was a typo on mobile. Yeah seems like a regression. infinity or 0 should work, but don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants