Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked encoding reception is wrong #624

Open
craff opened this issue Jun 29, 2023 · 3 comments
Open

chunked encoding reception is wrong #624

craff opened this issue Jun 29, 2023 · 3 comments

Comments

@craff
Copy link

craff commented Jun 29, 2023

Version and Runtime

Version: 
Commit: 
Runtime: go1.14.2 linux/amd64
Date: 

Expected Behaviour

According to the documentation, the chunked encoding is followed by a possibly empty sequence of headers
in HTTP 1.1, which means that there is at least one '\r\n' at the end. Firefox enters a loop if you do not provide this empty trailer.

Actual Behaviour

vegeta gives this if you do provide the empty trailer:

2023/06/28 15:58:16 Unsolicited response received on idle HTTP channel starting with "\r\n"; err=<nil>

Additional Context

documentation

@craff
Copy link
Author

craff commented Jun 29, 2023

Remark: trailer is not used not implemented by most browser. Still the empty trailer should be there.

@AlexanderYastrebov
Copy link
Contributor

go1.14.2

This is old go runtime.

Make sure you use latest vegeta version, see also #625

@tsenart
Copy link
Owner

tsenart commented Aug 18, 2023

Can you provide a reproduction program with latest version of Go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants