Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving expression detection #39

Open
Heliozoa opened this issue Aug 2, 2023 · 1 comment
Open

Improving expression detection #39

Heliozoa opened this issue Aug 2, 2023 · 1 comment

Comments

@Heliozoa
Copy link
Contributor

Heliozoa commented Aug 2, 2023

Hi,
I noticed that ichiran will currently segment "どこから見ても" as three separate words "どこ", "から" and "見ても", rather than the expression which has a JMdict entry. Same is true for some other expressions as well, such as 負の遺産 or 取り留めも無い. Other expressions like どう見ても do get detected as such. I don't know how difficult it would be, but it would be great if ichiran was able to detect these expressions more reliably.

@fasiha
Copy link
Contributor

fasiha commented Feb 1, 2024

Related? If I search Ichiran/ichi.moe for 写真を撮る it finds the literal JMdict entry (similarly to どこから見ても from above) but 写真を撮りました doesn't recognize that this is a conjugation of the longer entry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants