Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some css fixed #19

Open
bArraxas opened this issue Jun 10, 2019 · 4 comments · May be fixed by #67
Open

Some css fixed #19

bArraxas opened this issue Jun 10, 2019 · 4 comments · May be fixed by #67

Comments

@bArraxas
Copy link

I use bootstrap v4.3.1 and and select2-bootstrap4-them v1.2.2
The background of select is grey at place of white.
And it seem labels are not correctly aligned verticaly.
I had fixed the problem with those lines :
.select2 { background-color: #fff; }
.select2-container--bootstrap4 .select2-selection--single .select2-selection__rendered { line-height: 2.45em; }
.select2-container--bootstrap4 .select2-selection--multiple .select2-selection__choice { margin-top: 0.5em; }

Thanks for your job ;-)
@ttskch
Copy link
Owner

ttskch commented Jul 12, 2019

@bArraxas Could you please show some sample html which reproduces the problem?

@dchevilletRDR
Copy link

Hi,

@ttskch I think we have the same problem, here a picture :
Screenshot-2020-1-3 Groupe

But the correction is not totally correct for us:
Screenshot-2020-1-3 Groupe(1)

Thanks :-)

@ttskch
Copy link
Owner

ttskch commented Apr 24, 2020

@dchevilletRDR Could you please show some reproducing html?

@weberhofer
Copy link

Please check PR #56, have fixed that there.

tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 3, 2021
@tagliala
Add compatibility with Select2 4.1
c592be9 
- Uses Bootstrap's `custom-select` implementation for uniformity
- Use SVG background image for clear button
- Add some lints to improve code readability
- Use the same Browserlist configuration as Bootstrap 4.6

Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu

Close: ttskch#49, ttskch#60, ttskch#61, ttskch#19
@tagliala tagliala linked a pull request Mar 3, 2021 that will close this issue
Draft
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 13, 2021
@tagliala
Add compatibility with Select2 4.1
67d9719 
- Uses Bootstrap's `custom-select` implementation for uniformity
- Use SVG background image for clear button
- Add some lints to improve code readability
- Use the same Browserlist configuration as Bootstrap 4.6

Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu

Close: ttskch#49, ttskch#60, ttskch#61, ttskch#19
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
@tagliala
Add compatibility with Select2 4.1
1fb197b 
- Uses Bootstrap's `custom-select` implementation for uniformity
- Use SVG background image for clear button
- Add some lints to improve code readability
- Use the same Browserlist configuration as Bootstrap 4.6

Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu

Close: ttskch#49, ttskch#60, ttskch#61, ttskch#19
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
@tagliala
Add compatibility with Select2 4.1
41917f4 
- Uses Bootstrap's `custom-select` implementation for uniformity
- Use SVG background image for clear button
- Add some lints to improve code readability
- Use the same Browserlist configuration as Bootstrap 4.6

Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu

Close: ttskch#49, ttskch#60, ttskch#61, ttskch#19
tagliala added a commit to tagliala/select2-bootstrap4-theme that referenced this issue Mar 14, 2021
@tagliala
Add compatibility with Select2 4.1
6ea50fe 
- Uses Bootstrap's `custom-select` implementation for uniformity
- Use SVG background image for clear button
- Add some lints to improve code readability
- Use the same Browserlist configuration as Bootstrap 4.6

Ref: https://getbootstrap.com/docs/4.6/components/forms/#select-menu

Close: ttskch#49, ttskch#60, ttskch#61, ttskch#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor as custom select + Select2 4.1 compatibility tagliala/select2-bootstrap4-theme
4 participants
@weberhofer @ttskch @bArraxas @dchevilletRDR