Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme override addon-note #199

Open
kbhutiya opened this issue Jul 19, 2019 · 1 comment
Open

Readme override addon-note #199

kbhutiya opened this issue Jul 19, 2019 · 1 comment

Comments

@kbhutiya
Copy link

Hi there,
I have a story where I am using add-on-notes for Notes panel and also readme, somehow every time I use readme it overrides notes !
It depends on which one is written first will render !
For eg.

.add(`Demo1`, () => `
<asdi-accordion>
  <asdi-bar>
  <asdi-note>
</asdi-accordion>
`,{ notes:`Single Accordion`},
	{ readme: { sidebar:`
<asdi-accordion>
  <asdi-bar>
  <asdi-note>
</asdi-accordion>
`}})

Do you have any suggestions for the same?

@tuchk4
Copy link
Owner

tuchk4 commented Aug 2, 2019

Seems function add in your example is with wrong arguments.

Try this.

A.add(
  `Demo1`,
  () => `
<asdi-accordion>
  <asdi-bar>
  <asdi-note>
</asdi-accordion>
`,
  {
    notes: `Single Accordion`,
    readme: {
      sidebar: `
<asdi-accordion>
  <asdi-bar>
  <asdi-note>
</asdi-accordion>
`,
    },
  },
);

The original issue cant reporoduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants