Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.8 breaks IE11 #209

Open
Grzegorz-PC-x opened this issue Aug 22, 2019 · 1 comment
Open

5.0.8 breaks IE11 #209

Grzegorz-PC-x opened this issue Aug 22, 2019 · 1 comment

Comments

@Grzegorz-PC-x
Copy link

I recently updated @storybook/react to v5.1.11 and storybook-readme to 5.0.8 (from v4).
Unfortunately after adding import { addReadme } from 'storybook-readme/html'; to my project, SB in IE11 is totally broken.

From what I can see SB contains an arrow function in vendor file. It happens only if storybook-readme is included.

To reproduce innit a clean Storybook example code and add the above import in config.js

Please fix the issue or provide walkaround as this stops my upgrade to SB5.

@natterstefan
Copy link

natterstefan commented Sep 9, 2019

Hi @Grzegorz-PC-x,

we are experiencing the same issue. After some research, we found out it's related to an issue reported in algolia/react-element-to-jsx-string#387 (another storybook addon has the same issue, eg. storybookjs/addon-jsx#20).

Unfortunately, adding this to the webpack.config.js did not (yet) resolve our issue:

Some of the dependencies that this package has use APIs not available in IE11. To get around this you can add the following to your webpack.config.js file (your paths might be slightly different):

config.module.rules.push({
  test: /\.js/,
  include: path.resolve(__dirname, '../node_modules/stringify-object'),
  use: [
    {
      loader: 'babel-loader',
      options: {
        presets: ['env']
      }
    }
  ]
});

Source: https://github.com/storybookjs/addon-jsx#usage-with-ie11

Until it's fixed we most likely downgrade storybook-readme.

At this point, I want to ask and highlight, that documenting changes in a CHANGELOG or in the release tab would be highly appreciated @tuchk4. Without them, it's always a hassle to update and debug undocumented releases of packages. Besides that, I appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants